clear _canReuse in setUrl if its not a local redirect (esp8266#7039)

liebman · devyte · commit 9e9515b49fe6 · 2020-01-28T00:35:16.000-03:00
diff --git a/libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp b/libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp
@@ -549,7 +549,8 @@ bool HTTPClient::setURL(const String& url)
         DEBUG_HTTPCLIENT("[HTTP-Client][setURL] new URL not the same protocol, expected '%s', URL: '%s'\n", _protocol.c_str(), url.c_str());
         return false;
     }
-    // disconnect but preserve _client
+    // disconnect but preserve _client (clear _canReuse so disconnect will close the connection)
+    _canReuse = false;
     disconnect(true);
     return beginInternal(url, nullptr);
 }

Original file line number	Diff line number	Diff line change
`@@ -549,7 +549,8 @@ bool HTTPClient::setURL(const String& url)`
`549`	`549`	`DEBUG_HTTPCLIENT("[HTTP-Client][setURL] new URL not the same protocol, expected '%s', URL: '%s'\n", _protocol.c_str(), url.c_str());`
`550`	`550`	`return false;`
`551`	`551`	`}`
`552`		`- // disconnect but preserve _client`
	`552`	`+ // disconnect but preserve _client (clear _canReuse so disconnect will close the connection)`
	`553`	`+ _canReuse = false;`
`553`	`554`	`disconnect(true);`
`554`	`555`	`return beginInternal(url, nullptr);`
`555`	`556`	`}`