Apply suggestions from code review

Co-authored-by: Max Prokhorov <[email protected]>

Author: dok-net

cores/esp8266/core_esp8266_main.cpp

@@ -163,13 +163,11 @@ extern "C" void __esp_delay(unsigned long ms) {
 extern "C" void esp_delay(unsigned long ms) __attribute__((weak, alias("__esp_delay")));
 
 bool try_esp_delay(const uint32_t start_ms, const uint32_t timeout_ms, const uint32_t intvl_ms) {
-    decltype(millis()) expired;
-
-    if ((expired = millis() - start_ms) >= timeout_ms) {
+    uint32_t expired = millis() - start_ms;
+    if (expired >= timeout_ms) {
         return true;
     }
-    const auto remaining = timeout_ms - expired;
-    esp_delay(remaining <= intvl_ms ? remaining : intvl_ms);
+    esp_delay(std::min((timeout_ms - expired), intvl_ms));
     return false;
 }
 

libraries/ESP8266WiFi/src/ESP8266WiFiGeneric.cpp

@@ -630,10 +630,10 @@ int ESP8266WiFiGenericClass::hostByName(const char* aHostname, IPAddress& aResul
     if(err == ERR_OK) {
         DEBUG_WIFI_GENERIC("[hostByName] Host: %s IP: %s\n", aHostname, aResult.toString().c_str());
         return 1;
-    } else {
-        DEBUG_WIFI_GENERIC("[hostByName] Host: %s lookup error: %d!\n", aHostname, (int)err);
-        return 0;
     }
+    
+    DEBUG_WIFI_GENERIC("[hostByName] Host: %s lookup error: %s (%d)!\n", aHostname, lwip_strerr(err), (int)err);
+    return 0;
 }
 
 #if LWIP_IPV4 && LWIP_IPV6
@@ -680,10 +680,10 @@ int ESP8266WiFiGenericClass::hostByName(const char* aHostname, IPAddress& aResul
     if(err == ERR_OK) {
         DEBUG_WIFI_GENERIC("[hostByName] Host: %s IP: %s\n", aHostname, aResult.toString().c_str());
         return 1;
-    } else {
-        DEBUG_WIFI_GENERIC("[hostByName] Host: %s lookup error: %d!\n", aHostname, (int)err);
-        return 0;
     }
+
+    DEBUG_WIFI_GENERIC("[hostByName] Host: %s lookup error: %d!\n", aHostname, (int)err);
+    return 0;
 }
 #endif