Run lint in our own tests. Fixes #240 (#480)

Author: tmcw

index.js

@@ -208,7 +208,7 @@ function buildSync(indexes, options) {
  * @returns {undefined} calls callback
  * @public
  */
-module.exports.lint = function lint(indexes, options, callback) {
+function lint(indexes, options, callback) {
   options = options || {};
 
   if (typeof indexes === 'string') {
@@ -241,11 +241,7 @@ module.exports.lint = function lint(indexes, options, callback) {
             nest))
           .filter(Boolean))));
   });
-};
-
-module.exports.expandInputs = expandInputs;
-module.exports.buildSync = buildSync;
-module.exports.build = build;
+}
 
 /**
  * Documentation's formats are modular methods that take comments
@@ -254,7 +250,7 @@ module.exports.build = build;
  * output.
  * @public
  */
-module.exports.formats = {
+var formats = {
   html: require('./lib/output/html'),
   md: require('./lib/output/markdown'),
   remark: function (comments, options, callback) {
@@ -265,6 +261,12 @@ module.exports.formats = {
   json: require('./lib/output/json')
 };
 
+module.exports.lint = lint;
+module.exports.expandInputs = expandInputs;
+module.exports.buildSync = buildSync;
+module.exports.build = build;
+module.exports.formats = formats;
+
 module.exports.util = {
   createFormatters: require('./lib/output/util/formatters'),
   createLinkerStack: require('./lib/output/util/linker_stack')

lib/filter_js.js

@@ -10,7 +10,7 @@ var path = require('path');
  * expect as argument a file as an objectg with the 'file' property
  *
  * @private
- * @param {String|Array} extension to be filtered
+ * @param {string|Array} extension to be filtered
  * @param {boolean} allowAll ignore the entire extension check and always
  * pass through files. This is used by the polglot mode.
  * @return {Function} a filter function, this function returns true if the input filename extension

lib/module_filters.js

@@ -8,6 +8,10 @@ var internalModuleRegexp = process.platform === 'win32' ?
   /^(\.|\w:)/ :
   /^[\/.]/;
 
+/**
+ * Module filters
+ * @private
+ */
 module.exports = {
   internalOnly: internalModuleRegexp.test.bind(internalModuleRegexp),
 

lib/output/util/format_type.js

@@ -15,7 +15,7 @@ function t(text) {
  * Helper used to automatically link items to global JS documentation or to internal
  * documentation.
  *
- * @param {String} text - text to potentially link
+ * @param {string} text - text to potentially link
  * @param {function} [getHref] - a function that tries
  * to find a URL to point a named link to
  * @param {string} description text that will be shown to the user, if this

package.json

@@ -82,6 +82,7 @@
   "scripts": {
     "lint": "eslint bin lib index.js test",
     "doc": "documentation index.js -f md --access=public > docs/NODE_API.md",
-    "test": "npm run lint && tap -t 120 --coverage test/*.js test/lib test/streams"
+    "self-lint": "node ./bin/documentation.js lint",
+    "test": "npm run lint && npm run self-lint && tap -t 120 --coverage test/*.js test/lib test/streams"
   }
 }