Fix exception when formatting lint errors

Author: Lucas Wojciechowski

lib/parse.js

@@ -36,7 +36,7 @@ function parseJSDoc(comment, loc, context) {
     var tag = result.tags[i];
     if (tag.errors) {
       for (var j = 0; j < tag.errors.length; j++) {
-        result.errors.push(tag.errors[j]);
+        result.errors.push({message: tag.errors[j]});
       }
       result.tags.splice(i, 1);
     } else {

test/lib/lint.js

@@ -2,7 +2,8 @@
 
 var test = require('tap').test,
   parse = require('../../lib/parsers/javascript'),
-  lint = require('../../lib/lint').lint;
+  lint = require('../../lib/lint').lint,
+  format = require('../../lib/lint').format;
 
 function toComment(fn, filename) {
   return parse({
@@ -20,8 +21,11 @@ test('lint', function (t) {
     /**
      * @param {String} foo
      * @param {array} bar
+     * @param {foo
      */
   }).errors, [
+    { message: 'Braces are not balanced' },
+    { message: 'Missing or invalid tag name' },
     { commentLineNumber: 1, message: 'type String found, string is standard' },
     { commentLineNumber: 2, message: 'type array found, Array is standard' }],
     'non-canonical');
@@ -40,3 +44,24 @@ test('lint', function (t) {
 
   t.end();
 });
+
+test('format', function (t) {
+  var comment = evaluate(function () {
+    /**
+     * @param {String} foo
+     * @param {array} bar
+     * @param {foo
+     */
+  });
+
+  var formatted = format([comment]);
+
+  t.contains(formatted, 'input.js');
+  t.contains(formatted, /1:1[^\n]+Braces are not balanced/);
+  t.contains(formatted, /1:1[^\n]+Missing or invalid tag name/);
+  t.contains(formatted, /3:1[^\n]+type String found, string is standard/);
+  t.contains(formatted, /4:1[^\n]+type array found, Array is standard/);
+  t.contains(formatted, '4 warnings');
+
+  t.end();
+});

test/lib/parsers/javascript.js

@@ -21,7 +21,7 @@ test('parse - error', function (t) {
   t.deepEqual(toComment(function () {
     /** @param {foo */
   })[0].errors, [
-    'Braces are not balanced',
-    'Missing or invalid tag name']);
+    { message: 'Braces are not balanced' },
+    { message: 'Missing or invalid tag name' }]);
   t.end();
 });