Skip to content

Commit 388ceba

Browse files
committed
convert some DOM creation code to Solid JSX
This updates Rollup and replaces Buble with Babel (we're already using Babel anyway) to add babel-preset-solid for compiling Solid JSX expressions. At the moment this breaks the current SSR feature.
1 parent e424a9d commit 388ceba

File tree

10 files changed

+26280
-361
lines changed

10 files changed

+26280
-361
lines changed

build/build.js

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
const rollup = require('rollup')
2-
const buble = require('rollup-plugin-buble')
3-
const commonjs = require('rollup-plugin-commonjs')
4-
const nodeResolve = require('rollup-plugin-node-resolve')
5-
const { uglify } = require('rollup-plugin-uglify')
6-
const replace = require('rollup-plugin-replace')
2+
const babel = require('@rollup/plugin-babel').default
3+
const commonjs = require('@rollup/plugin-commonjs')
4+
const nodeResolve = require('@rollup/plugin-node-resolve').default
5+
const { terser: uglify } = require('rollup-plugin-terser')
6+
const replace = require('@rollup/plugin-replace')
77
const isProd = process.env.NODE_ENV === 'production'
88
const version = process.env.VERSION || require('../package.json').version
99
const chokidar = require('chokidar')
@@ -22,10 +22,10 @@ async function build(opts) {
2222
.rollup({
2323
input: opts.input,
2424
plugins: (opts.plugins || []).concat([
25-
buble({
26-
transforms: {
27-
dangerousForOf: true
28-
}}),
25+
babel({
26+
babelHelpers: "bundled",
27+
presets: ['babel-preset-solid']
28+
}),
2929
commonjs(),
3030
nodeResolve(),
3131
replace({
@@ -49,10 +49,12 @@ async function build(opts) {
4949

5050
console.log(dest)
5151
return bundle.write({
52-
format: 'iife',
53-
output: opts.globalName ? {name: opts.globalName} : {},
54-
file: dest,
55-
strict: false
52+
output: {
53+
format: 'iife',
54+
name: opts.globalName,
55+
file: dest,
56+
strict: false
57+
},
5658
})
5759
})
5860
}

build/ssr.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
var rollup = require('rollup')
2-
var buble = require('rollup-plugin-buble')
2+
var babel = require('@rollup/plugin-babel').default
33
var async = require('rollup-plugin-async')
4-
var replace = require('rollup-plugin-replace')
4+
var replace = require('@rollup/plugin-replace')
55

66
rollup
77
.rollup({
@@ -12,11 +12,10 @@ rollup
1212
__VERSION__: process.env.VERSION || require('../package.json').version,
1313
'process.env.SSR': true
1414
}),
15-
buble({
16-
transforms: {
17-
generator: false
18-
}
19-
})
15+
babel({
16+
babelHelpers: "bundled",
17+
presets: ['babel-preset-solid']
18+
}),
2019
],
2120
onwarn: function () {}
2221
})

0 commit comments

Comments
 (0)