cli/command/system: remove redundant nil-check (gosimple)

thaJeztah · thaJeztah · commit d8af7812b596 · 2024-08-26T14:38:37.000+02:00
cli/command/system/info.go:375:5: S1009: should omit nil check; len() for []github.com/docker/docker/api/types/system.NetworkAddressPool is defined as zero (gosimple) if info.DefaultAddressPools != nil && len(info.DefaultAddressPools) > 0 { ^ Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit cc1d7b7) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
diff --git a/cli/command/system/info.go b/cli/command/system/info.go
@@ -372,7 +372,7 @@ func prettyPrintServerInfo(streams command.Streams, info *dockerInfo) []error {
 		fprintln(output, " Product License:", info.ProductLicense)
 	}
 
-	if info.DefaultAddressPools != nil && len(info.DefaultAddressPools) > 0 {
+	if len(info.DefaultAddressPools) > 0 {
 		fprintln(output, " Default Address Pools:")
 		for _, pool := range info.DefaultAddressPools {
 			fprintf(output, "   Base: %s, Size: %d\n", pool.Base, pool.Size)

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ func prettyPrintServerInfo(streams command.Streams, info *dockerInfo) []error {`
`372`	`372`	`fprintln(output, " Product License:", info.ProductLicense)`
`373`	`373`	`}`
`374`	`374`
`375`		`- if info.DefaultAddressPools != nil && len(info.DefaultAddressPools) > 0 {`
	`375`	`+ if len(info.DefaultAddressPools) > 0 {`
`376`	`376`	`fprintln(output, " Default Address Pools:")`
`377`	`377`	`for _, pool := range info.DefaultAddressPools {`
`378`	`378`	`fprintf(output, " Base: %s, Size: %d\n", pool.Base, pool.Size)`