plugins/hooks: run hooks when exit code != 0

Particularly for cases such as `docker exec -it`, it's relevant that the CLI
still executes hooks even if the exec exited with a non-zero exit code,
since this is can be part of a normal `docker exec` invocation depending on
how the user exits.

In the future, this might also be interesting to allow plugins to run
hooks after an error so they can offer error-state recovery suggestions,
although this would require additional work to give the plugin more
information about the failed execution.

Signed-off-by: Laura Brehm <[email protected]>

Author: laurazard

cmd/docker/docker.go

@@ -353,17 +353,14 @@ func runDocker(ctx context.Context, dockerCli *command.DockerCli) error {
 	// which remain.
 	cmd.SetArgs(args)
 	err = cmd.Execute()
-	if err != nil {
-		return err
-	}
 
 	// If the command is being executed in an interactive terminal,
 	// run the plugin hooks (but don't throw an error if something misbehaves)
 	if dockerCli.HooksEnabled() && dockerCli.Out().IsTerminal() && subCommand != nil {
 		_ = pluginmanager.RunPluginHooks(dockerCli, cmd, subCommand, "", args)
 	}
 
-	return nil
+	return err
 }
 
 type versionDetails interface {