Skip to content

Commit 64b9e4c

Browse files
committed
cli: rename args that collided with builtins (predeclard)
cli/required.go:33:22: param min has same name as predeclared identifier (predeclared) func RequiresMinArgs(min int) cobra.PositionalArgs { ^ cli/required.go:50:22: param max has same name as predeclared identifier (predeclared) func RequiresMaxArgs(max int) cobra.PositionalArgs { ^ cli/required.go:67:24: param min has same name as predeclared identifier (predeclared) func RequiresRangeArgs(min int, max int) cobra.PositionalArgs { ^ Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit c4a55df) Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 4b71d0d commit 64b9e4c

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

cli/required.go

+13-13
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,16 @@ func NoArgs(cmd *cobra.Command, args []string) error {
2727
}
2828

2929
// RequiresMinArgs returns an error if there is not at least min args
30-
func RequiresMinArgs(min int) cobra.PositionalArgs {
30+
func RequiresMinArgs(minArgs int) cobra.PositionalArgs {
3131
return func(cmd *cobra.Command, args []string) error {
32-
if len(args) >= min {
32+
if len(args) >= minArgs {
3333
return nil
3434
}
3535
return errors.Errorf(
3636
"%q requires at least %d %s.\nSee '%s --help'.\n\nUsage: %s\n\n%s",
3737
cmd.CommandPath(),
38-
min,
39-
pluralize("argument", min),
38+
minArgs,
39+
pluralize("argument", minArgs),
4040
cmd.CommandPath(),
4141
cmd.UseLine(),
4242
cmd.Short,
@@ -45,16 +45,16 @@ func RequiresMinArgs(min int) cobra.PositionalArgs {
4545
}
4646

4747
// RequiresMaxArgs returns an error if there is not at most max args
48-
func RequiresMaxArgs(max int) cobra.PositionalArgs {
48+
func RequiresMaxArgs(maxArgs int) cobra.PositionalArgs {
4949
return func(cmd *cobra.Command, args []string) error {
50-
if len(args) <= max {
50+
if len(args) <= maxArgs {
5151
return nil
5252
}
5353
return errors.Errorf(
5454
"%q requires at most %d %s.\nSee '%s --help'.\n\nUsage: %s\n\n%s",
5555
cmd.CommandPath(),
56-
max,
57-
pluralize("argument", max),
56+
maxArgs,
57+
pluralize("argument", maxArgs),
5858
cmd.CommandPath(),
5959
cmd.UseLine(),
6060
cmd.Short,
@@ -63,17 +63,17 @@ func RequiresMaxArgs(max int) cobra.PositionalArgs {
6363
}
6464

6565
// RequiresRangeArgs returns an error if there is not at least min args and at most max args
66-
func RequiresRangeArgs(min int, max int) cobra.PositionalArgs {
66+
func RequiresRangeArgs(minArgs int, maxArgs int) cobra.PositionalArgs {
6767
return func(cmd *cobra.Command, args []string) error {
68-
if len(args) >= min && len(args) <= max {
68+
if len(args) >= minArgs && len(args) <= maxArgs {
6969
return nil
7070
}
7171
return errors.Errorf(
7272
"%q requires at least %d and at most %d %s.\nSee '%s --help'.\n\nUsage: %s\n\n%s",
7373
cmd.CommandPath(),
74-
min,
75-
max,
76-
pluralize("argument", max),
74+
minArgs,
75+
maxArgs,
76+
pluralize("argument", maxArgs),
7777
cmd.CommandPath(),
7878
cmd.UseLine(),
7979
cmd.Short,

0 commit comments

Comments
 (0)