Skip to content

Commit 7440916

Browse files
committed
implement requested changes
issue spring-projects#3501
1 parent bec337c commit 7440916

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

spring-integration-graphql/src/main/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandler.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,14 @@ public void setQueryExpression(Expression queryExpression) {
8080
* @param operationName the GraphQL Operation Name to use.
8181
*/
8282
public void setOperationName(String operationName) {
83-
setOperationNameTypeExpression(new LiteralExpression(operationName));
83+
setOperationNameExpression(new LiteralExpression(operationName));
8484
}
8585

8686
/**
8787
* Set a SpEL expression to evaluate a GraphQL Operation Name to execute.
8888
* @param operationNameExpression the expression to use.
8989
*/
90-
public void setOperationNameTypeExpression(Expression operationNameExpression) {
90+
public void setOperationNameExpression(Expression operationNameExpression) {
9191
Assert.notNull(operationNameExpression, "'operationNameExpression' must not be null");
9292
this.operationNameExpression = operationNameExpression;
9393
}
@@ -129,20 +129,18 @@ else if (requestMessage.getPayload() instanceof String && !Strings.isNullOrEmpty
129129
}
130130
}
131131

132-
String evaluateQueryExpression(Message<?> message) {
132+
private String evaluateQueryExpression(Message<?> message) {
133133
String query = this.queryExpression.getValue(this.evaluationContext, message, String.class);
134134
Assert.notNull(query, "'queryExpression' must not evaluate to null");
135135
return query;
136136
}
137137

138-
String evaluateOperationNameExpression(Message<?> message) {
139-
Assert.notNull(this.operationNameExpression, "'operationNameExpression' must not be null when 'query' mode is used");
138+
private String evaluateOperationNameExpression(Message<?> message) {
140139
return this.operationNameExpression.getValue(this.evaluationContext, message, String.class);
141140
}
142141

143142
@SuppressWarnings("unchecked")
144-
Map<String, Object> evaluateVariablesExpression(Message<?> message) {
145-
Assert.notNull(this.variablesExpression, "'variablesExpression' must not be null when 'query' mode is used");
143+
private Map<String, Object> evaluateVariablesExpression(Message<?> message) {
146144
return this.variablesExpression.getValue(this.evaluationContext, message, Map.class);
147145
}
148146

spring-integration-graphql/src/test/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandlerTests.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -313,10 +313,6 @@ void testHandleMessageForSubscriptionWithInvalidPayload() {
313313

314314
}
315315

316-
private static <T> T waitFor(Mono<T> mono) {
317-
return mono.block(Duration.ofSeconds(10));
318-
}
319-
320316
@Controller
321317
static class GraphQlController {
322318

0 commit comments

Comments
 (0)