Skip to content

Commit 5744503

Browse files
committed
rename tests for clarity
issue spring-projects#3501
1 parent 1969516 commit 5744503

File tree

1 file changed

+3
-47
lines changed

1 file changed

+3
-47
lines changed

spring-integration-graphql/src/test/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandlerTests.java

Lines changed: 3 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
import org.springframework.integration.dsl.IntegrationFlow;
4646
import org.springframework.integration.dsl.IntegrationFlows;
4747
import org.springframework.integration.dsl.MessageChannels;
48-
import org.springframework.integration.expression.FunctionExpression;
4948
import org.springframework.messaging.Message;
5049
import org.springframework.messaging.MessageHandlingException;
5150
import org.springframework.messaging.PollableChannel;
@@ -89,7 +88,7 @@ public class GraphQlMessageHandlerTests {
8988

9089
@Test
9190
@SuppressWarnings("unchecked")
92-
void testHandleMessageForQuery() {
91+
void testHandleMessageForQueryWithRequestInputProvided() {
9392

9493
StepVerifier verifier = StepVerifier.create(
9594
Flux.from(this.resultChannel)
@@ -136,50 +135,7 @@ void testHandleMessageForQueryWithQueryProvided() {
136135

137136
@Test
138137
@SuppressWarnings("unchecked")
139-
void testHandleMessageForQueryWithQueryAndOperationProvided() {
140-
141-
String fakeQuery = "query FriendlyName { testQuery { id } }";
142-
this.graphQlMessageHandler.setQuery(fakeQuery);
143-
this.graphQlMessageHandler.setOperationName("FriendlyName");
144-
145-
StepVerifier.create(
146-
Mono.from((Mono<ExecutionResult>) this.graphQlMessageHandler.handleRequestMessage(MessageBuilder.withPayload(fakeQuery).build()))
147-
)
148-
.consumeNextWith(result -> {
149-
assertThat(result).isInstanceOf(ExecutionResultImpl.class);
150-
Map<String, Object> data = result.getData();
151-
Map<String, Object> testQuery = (Map<String, Object>) data.get("testQuery");
152-
assertThat(testQuery.get("id")).isEqualTo("test-data");
153-
})
154-
.expectComplete()
155-
.verify();
156-
}
157-
158-
@Test
159-
@SuppressWarnings("unchecked")
160-
void testHandleMessageForQueryWithQueryAndOperationNameAndVariablesProvided() {
161-
162-
String fakeQuery = "query FriendlyName($id: String) { testQueryById(id: $id) { id } }";
163-
this.graphQlMessageHandler.setQuery(fakeQuery);
164-
this.graphQlMessageHandler.setOperationName("FriendlyName");
165-
this.graphQlMessageHandler.setVariablesExpression(new FunctionExpression<>(m -> Map.of("$id", "test-data")));
166-
167-
StepVerifier.create(
168-
Mono.from((Mono<ExecutionResult>) this.graphQlMessageHandler.handleRequestMessage(MessageBuilder.withPayload(fakeQuery).build()))
169-
)
170-
.consumeNextWith(result -> {
171-
assertThat(result).isInstanceOf(ExecutionResultImpl.class);
172-
Map<String, Object> data = result.getData();
173-
Map<String, Object> testQuery = (Map<String, Object>) data.get("testQueryById");
174-
assertThat(testQuery.get("id")).isEqualTo("test-data");
175-
})
176-
.expectComplete()
177-
.verify();
178-
}
179-
180-
@Test
181-
@SuppressWarnings("unchecked")
182-
void testHandleMessageForMutation() {
138+
void testHandleMessageForMutationWithRequestInputProvided() {
183139

184140
String fakeId = UUID.randomUUID().toString();
185141
Update expected = new Update(fakeId);
@@ -218,7 +174,7 @@ void testHandleMessageForMutation() {
218174

219175
@Test
220176
@SuppressWarnings("unchecked")
221-
void testHandleMessageForSubscription() {
177+
void testHandleMessageForSubscriptionWithRequestInputProvided() {
222178

223179
StepVerifier verifier = StepVerifier.create(
224180
Flux.from(this.resultChannel)

0 commit comments

Comments
 (0)