Skip to content

Commit 05e369c

Browse files
committed
implement requested feedback
issue spring-projects#3501
1 parent 977cf01 commit 05e369c

File tree

10 files changed

+37
-9
lines changed

10 files changed

+37
-9
lines changed

build.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -529,8 +529,6 @@ project('spring-integration-graphql') {
529529
dependencies {
530530
api project(':spring-integration-core')
531531
api "org.springframework.graphql:spring-graphql:$springGraphqlVersion"
532-
533-
testImplementation "org.springframework.graphql:spring-graphql-test:$springGraphqlVersion"
534532
}
535533
}
536534

spring-integration-graphql/src/main/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandler.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,24 @@
2020
import org.springframework.graphql.RequestInput;
2121
import org.springframework.integration.handler.AbstractReplyProducingMessageHandler;
2222
import org.springframework.messaging.Message;
23+
import org.springframework.util.Assert;
2324

2425
import graphql.ExecutionResult;
2526
import reactor.core.publisher.Mono;
2627

2728
/**
28-
* A <code>MessageHandler</code> capable of fielding GraphQL Query, Mutation and Subscription requests.
29+
* A {@link org.springframework.messaging.MessageHandler} capable of fielding GraphQL Query, Mutation and Subscription requests.
2930
*
3031
* @author Daniel Frey
32+
* @since 6.0
3133
*/
3234
public class GraphQlMessageHandler extends AbstractReplyProducingMessageHandler {
3335

3436
private final GraphQlService graphQlService;
3537

3638
public GraphQlMessageHandler(final GraphQlService graphQlService) {
39+
Assert.notNull(graphQlService, "'graphQlService' must not be null");
40+
3741
this.graphQlService = graphQlService;
3842
setAsync(true);
3943
}
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
package org.springframework.integration.graphql.outbound;
1+
package org.springframework.integration.graphql.outbound;

spring-integration-graphql/src/main/java/org/springframework/integration/graphql/package-info.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
* Root package of the Spring Integration GraphQL module, which contains various
33
* GraphQL Query, Mutation and Subscription components
44
*/
5-
package org.springframework.integration.graphql;
5+
package org.springframework.integration.graphql;

spring-integration-graphql/src/test/java/org/springframework/integration/graphql/outbound/GraphQlMessageHandlerTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@
6565
/**
6666
*
6767
* @author Daniel Frey
68-
*
68+
* @since 6.0
6969
*/
70-
@SpringJUnitConfig(GraphQlMessageHandlerTests.TestConfig.class)
70+
@SpringJUnitConfig
7171
@DirtiesContext
7272
public class GraphQlMessageHandlerTests {
7373

spring-integration-graphql/src/test/resources/graphql/test-schema.graphqls

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ type QueryResult {
1616

1717
type Update {
1818
id: String
19-
}
19+
}

spring-integration-graphql/src/test/resources/log4j2-test.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
</Console>
77
</Appenders>
88
<Loggers>
9-
<Logger name="test" level="debug"/>
109
<Logger name="org.springframework" level="warn"/>
1110
<Logger name="org.springframework.graphql" level="warn"/>
1211
<Logger name="org.springframework.integration.graphql" level="warn"/>

src/reference/asciidoc/graphql.adoc

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
[[graphql]]
2+
== GraphQL Support
3+
4+
Spring Integration provides support for GraphQL.
5+
6+
You need to include this dependency into your project:
7+
8+
====
9+
.Maven
10+
[source, xml, subs="normal"]
11+
----
12+
<dependency>
13+
<groupId>org.springframework.integration</groupId>
14+
<artifactId>spring-integration-graphql</artifactId>
15+
<version>{project-version}</version>
16+
</dependency>
17+
----
18+
19+
.Gradle
20+
[source, groovy, subs="normal"]
21+
----
22+
compile "org.springframework.integration:spring-integration-graphql:{project-version}"
23+
----
24+
====

src/reference/asciidoc/index-single.adoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ include::./ftp.adoc[]
4141

4242
include::./gemfire.adoc[]
4343

44+
include::./graphql.adoc[]
45+
4446
include::./http.adoc[]
4547

4648
include::./jdbc.adoc[]

src/reference/asciidoc/index.adoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ This documentation is also available as single searchable link:index-single.html
3030
<<./file.adoc#files,File Support>> ::
3131
<<./ftp.adoc#ftp,FTP/FTPS Adapters>> ::
3232
<<./gemfire.adoc#gemfire,Pivotal GemFire and Apache Geode Support>> ::
33+
<<./graphql.adoc#graphql,GraphQL Support>> ::
3334
<<./http.adoc#http,HTTP Support>> ::
3435
<<./jdbc.adoc#jdbc,JDBC Support>> ::
3536
<<./jpa.adoc#jpa,JPA Support>> ::

0 commit comments

Comments
 (0)