Add a comment explaining why the safety check is there.

nlewycky · nlewycky · commit a2c3559a34e1 · 2020-04-06T15:52:24.000-07:00
diff --git a/src/values/instruction_value.rs b/src/values/instruction_value.rs
@@ -183,6 +183,7 @@ impl<'ctx> InstructionValue<'ctx> {
     }
 
     pub fn is_tail_call(&self) -> bool {
+        // LLVMIsTailCall has UB if the value is not an llvm::CallInst*.
         if self.get_opcode() == InstructionOpcode::Call {
             unsafe {
                 LLVMIsTailCall(self.as_value_ref()) == 1

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ impl<'ctx> InstructionValue<'ctx> {`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`pub fn is_tail_call(&self) -> bool {`
	`186`	`+ // LLVMIsTailCall has UB if the value is not an llvm::CallInst*.`
`186`	`187`	`if self.get_opcode() == InstructionOpcode::Call {`
`187`	`188`	`unsafe {`
`188`	`189`	`LLVMIsTailCall(self.as_value_ref()) == 1`