Skip to content

Commit 6009cb4

Browse files
authored
Merge pull request #50 from dimastbk/calamine-0.23.1
deps: bump calamine to 0.23.1
2 parents 716650a + af486d1 commit 6009cb4

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

Cargo.toml

+7-3
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,13 @@ name = "python_calamine"
1414
crate-type = ["cdylib"]
1515

1616
[dependencies]
17-
calamine = {version = "0.22.1", features = ["dates"]}
18-
pyo3 = {version = "0.19.2", features = ["extension-module", "chrono", "generate-import-lib"]}
19-
chrono = {version = "0.4.28", features = ["serde"]}
17+
calamine = { version = "0.23.1", features = ["dates"] }
18+
pyo3 = { version = "0.19.2", features = [
19+
"extension-module",
20+
"chrono",
21+
"generate-import-lib",
22+
] }
23+
chrono = { version = "0.4.28", features = ["serde"] }
2024
pyo3-file = "0.7.0"
2125

2226
[build-dependencies]

src/types/workbook.rs

+2-6
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ impl SheetsEnum {
3737
fn worksheet_range(
3838
&mut self,
3939
name: &str,
40-
) -> Option<Result<calamine::Range<calamine::DataType>, Error>> {
40+
) -> Result<calamine::Range<calamine::DataType>, Error> {
4141
match self {
4242
SheetsEnum::File(f) => f.worksheet_range(name),
4343
SheetsEnum::FileLike(f) => f.worksheet_range(name),
@@ -159,11 +159,7 @@ impl CalamineWorkbook {
159159
}
160160

161161
fn get_sheet_by_name(&mut self, name: &str) -> PyResult<CalamineSheet> {
162-
let range = self
163-
.sheets
164-
.worksheet_range(name)
165-
.unwrap_or_else(|| Err(Error::Msg("Workbook is empty")))
166-
.map_err(err_to_py)?;
162+
let range = self.sheets.worksheet_range(name).map_err(err_to_py)?;
167163
Ok(CalamineSheet::new(name.to_owned(), range))
168164
}
169165

0 commit comments

Comments
 (0)