Improve isDouble to look for big integers.

gkellogg · davidlehn · commit 13965c19edc1 · 2020-01-25T17:47:27.000-05:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - JSON literal value handling issues (`null` and `[]`).
 - Always pass typeScopedContext to _expandObject.
 - Allow a keyword to exist when expanding in _expandObject when the key is `@included` or `@type`.
+- Improve isDouble to look for big integers.
 
 ## 2.0.2 - 2020-01-17
 
diff --git a/lib/types.js b/lib/types.js
@@ -32,7 +32,8 @@ api.isBoolean = v => (typeof v === 'boolean' ||
  *
  * @return true if the value is a double, false if not.
  */
-api.isDouble = v => api.isNumber(v) && String(v).indexOf('.') !== -1;
+api.isDouble = v => api.isNumber(v) &&
+  (String(v).indexOf('.') !== -1 || Math.abs(v) >= 1e21);
 
 /**
  * Returns true if the given value is an empty Object.
diff --git a/tests/test-common.js b/tests/test-common.js
@@ -337,15 +337,12 @@ const TEST_TYPES = {
         /html-manifest.jsonld#tr020$/,
         /html-manifest.jsonld#tr021$/,
         /html-manifest.jsonld#tr022$/,
-        // number fixes
-        /toRdf-manifest.jsonld#trt01$/,
         // IRI resolution
         /toRdf-manifest.jsonld#t0130$/,
         /toRdf-manifest.jsonld#t0131$/,
         /toRdf-manifest.jsonld#t0132$/,
-        // @vocab mapping
-        /toRdf-manifest.jsonld#te075$/,
         // Invalid Statement
+        /toRdf-manifest.jsonld#te075$/,
         /toRdf-manifest.jsonld#te111$/,
         /toRdf-manifest.jsonld#te112$/,
         // @import

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,8 @@ api.isBoolean = v => (typeof v === 'boolean' \|\|`
`32`	`32`	`*`
`33`	`33`	`* @return true if the value is a double, false if not.`
`34`	`34`	`*/`
`35`		`-api.isDouble = v => api.isNumber(v) && String(v).indexOf('.') !== -1;`
	`35`	`+api.isDouble = v => api.isNumber(v) &&`
	`36`	`+ (String(v).indexOf('.') !== -1 \|\| Math.abs(v) >= 1e21);`
`36`	`37`
`37`	`38`	`/**`
`38`	`39`	`* Returns true if the given value is an empty Object.`