Skip to content

CONTRACTS: place contracts after do for do-while loops #7557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

remi-delmas-3000
Copy link
Collaborator

This PR changes the syntax of do-while loop contracts from

do 
{
   body;
} while(guard)
__CPROVER_assigns(A)
__CPROVER_loop_invariant(I)
__CPROVER_decreases(D)
;
do
__CPROVER_assigns(A)
__CPROVER_loop_invariant(I)
__CPROVER_decreases(D)
{
   body;
} while(guard);

To make it more obvious that the invariant is going to be checked in the base case before entering the loop even once.

Remark: This is an internal change that will not break any existing user code since do-while loop contracts are still not officially supported.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Makes it more obvious that the base case invariant check
happens before entering the loop even once.
@remi-delmas-3000 remi-delmas-3000 added aws Bugs or features of importance to AWS CBMC users Code Contracts Function and loop contracts labels Feb 22, 2023
@qinheping
Copy link
Collaborator

LGTM

@remi-delmas-3000 remi-delmas-3000 merged commit e0ccfc8 into diffblue:develop Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants