STL frontend: Cut quotes from module names #4955
Conversation
MatWise
requested review from
kroening,
peterschrammel,
pkesseli and
tautschnig
as code owners
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 08ed51c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/120891266
Codecov Report
@@ Coverage Diff @@
## develop #4955 +/- ##
===========================================
+ Coverage 69.23% 69.24% +<.01%
===========================================
Files 1309 1309
Lines 108441 108453 +12
===========================================
+ Hits 75083 75096 +13
+ Misses 33358 33357 -1
Continue to review full report at Codecov.
|
This commit introduces an extra state to the STL scanner in order to detect if the current identifier is a module name. If it is, the surrounding quotes are cut. The quotes are syntactically required but do not contribute to the module names being unique, therefore cutting them is allowed. Doing so simplifies both the user and the language interface. Existing regression tests were changed in a way that all directly refer to the default entry point which was introduced by a past commit. One test, Function_Call2, is now responsible for checking the --function flag.
MatWise
force-pushed
the
feature/stl-module-name
branch
from
08ed51c to
053eab0
Compare
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 053eab0).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/121456784
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
This PR introduces an extra state to the STL scanner in order to detect if the current identifier is a module name. If it is, the surrounding quotes are cut.
The quotes are syntactically required but do not contribute to the module names being unique, therefore cutting them is allowed. Doing so simplifies both the user and the language interface. Existing regression tests were changed in a way that all directly refer to the default entry point which was introduced by a past commit. One test, Function_Call2, is now responsible for checking the --function flag.