From 8f8052a5b043f4fc053a383b7187fb4b154705c9 Mon Sep 17 00:00:00 2001 From: Owen Jones Date: Thu, 19 Jul 2018 17:03:50 +0100 Subject: [PATCH 1/2] Make directories match from root --- CODEOWNERS | 82 +++++++++++++++++++++++++++--------------------------- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index fa575bfb0a6..33b59528460 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -3,58 +3,58 @@ # These files should rarely change -src/big-int/ @kroening -src/ansi-c/ @kroening @tautschnig -src/assembler/ @kroening @tautschnig -src/goto-cc/ @kroening @tautschnig -src/linking/ @kroening @tautschnig -src/memory-models/ @kroening @tautschnig -src/goto-symex/ @kroening @tautschnig @peterschrammel -src/json/ @kroening @tautschnig @peterschrammel -src/langapi/ @kroening @tautschnig @peterschrammel -src/xmllang/ @kroening @tautschnig @peterschrammel -src/nonstd/ @smowton @peterschrammel -src/solvers/cvc @martin-cs @kroening -src/solvers/flattening @martin-cs @kroening @tautschnig @peterschrammel -src/solvers/floatbv @martin-cs @kroening -src/solvers/miniBDD @tautschnig @kroening -src/solvers/prop @martin-cs @kroening @tautschnig @peterschrammel -src/solvers/sat @martin-cs @kroening @tautschnig @peterschrammel -src/solvers/smt2 @martin-cs @tautschnig @peterschrammel -jbmc/src/miniz/ @smowton @mgudemann @peterschrammel +/src/big-int/ @kroening +/src/ansi-c/ @kroening @tautschnig +/src/assembler/ @kroening @tautschnig +/src/goto-cc/ @kroening @tautschnig +/src/linking/ @kroening @tautschnig +/src/memory-models/ @kroening @tautschnig +/src/goto-symex/ @kroening @tautschnig @peterschrammel +/src/json/ @kroening @tautschnig @peterschrammel +/src/langapi/ @kroening @tautschnig @peterschrammel +/src/xmllang/ @kroening @tautschnig @peterschrammel +/src/nonstd/ @smowton @peterschrammel +/src/solvers/cvc @martin-cs @kroening +/src/solvers/flattening @martin-cs @kroening @tautschnig @peterschrammel +/src/solvers/floatbv @martin-cs @kroening +/src/solvers/miniBDD @tautschnig @kroening +/src/solvers/prop @martin-cs @kroening @tautschnig @peterschrammel +/src/solvers/sat @martin-cs @kroening @tautschnig @peterschrammel +/src/solvers/smt2 @martin-cs @tautschnig @peterschrammel +/jbmc/src/miniz/ @smowton @mgudemann @peterschrammel # These files change frequently and changes are high-risk -src/cbmc/ @smowton @kroening @tautschnig @peterschrammel -src/goto-programs/ @smowton @kroening @tautschnig @peterschrammel @pkesseli -src/util/ @smowton @kroening @tautschnig @peterschrammel @pkesseli -src/solvers/refinement @martin-cs @romainbrenguier @peterschrammel -jbmc/src/java_bytecode/ @smowton @mgudemann @thk123 @cristina-david @cesaro @pkesseli @NathanJPhillips @peterschrammel -src/analyses/ @martin-cs @peterschrammel @chrisr-diffblue @thk123 @smowton -src/pointer-analysis/ @martin-cs @peterschrammel @chrisr-diffblue @smowton +/src/cbmc/ @smowton @kroening @tautschnig @peterschrammel +/src/goto-programs/ @smowton @kroening @tautschnig @peterschrammel @pkesseli +/src/util/ @smowton @kroening @tautschnig @peterschrammel @pkesseli +/src/solvers/refinement @martin-cs @romainbrenguier @peterschrammel +/jbmc/src/java_bytecode/ @smowton @mgudemann @thk123 @cristina-david @cesaro @pkesseli @NathanJPhillips @peterschrammel +/src/analyses/ @martin-cs @peterschrammel @chrisr-diffblue @thk123 @smowton +/src/pointer-analysis/ @martin-cs @peterschrammel @chrisr-diffblue @smowton # These files change frequently and changes are medium-risk -src/goto-analyzer/ @martin-cs @chrisr-diffblue @peterschrammel -src/goto-instrument/ @martin-cs @chrisr-diffblue @peterschrammel -src/goto-diff/ @tautschnig @peterschrammel -jbmc/src/jbmc/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel -jbmc/src/janalyzer/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel -jbmc/src/jdiff/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel -src/cpp/ @kroening @tautschnig @peterschrammel +/src/goto-analyzer/ @martin-cs @chrisr-diffblue @peterschrammel +/src/goto-instrument/ @martin-cs @chrisr-diffblue @peterschrammel +/src/goto-diff/ @tautschnig @peterschrammel +/jbmc/src/jbmc/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel +/jbmc/src/janalyzer/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel +/jbmc/src/jdiff/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel +/src/cpp/ @kroening @tautschnig @peterschrammel # These files change frequently and changes are low-risk -src/util/irep_ids.def @diffblue/cbmc-developers +/src/util/irep_ids.def @diffblue/cbmc-developers -unit/ @diffblue/cbmc-developers -regression/ @diffblue/cbmc-developers -jbmc/unit/ @diffblue/cbmc-developers -jbmc/regression/ @diffblue/cbmc-developers +/unit/ @diffblue/cbmc-developers +/regression/ @diffblue/cbmc-developers +/jbmc/unit/ @diffblue/cbmc-developers +/jbmc/regression/ @diffblue/cbmc-developers -scripts/ @diffblue/devops @thk123 @forejtv @peterschrammel -.travis.yml @diffblue/devops @thk123 @forejtv @peterschrammel -appveyor.yml @diffblue/devops @thk123 @forejtv @peterschrammel +/scripts/ @diffblue/devops @thk123 @forejtv @peterschrammel +/.travis.yml @diffblue/devops @thk123 @forejtv @peterschrammel +/appveyor.yml @diffblue/devops @thk123 @forejtv @peterschrammel From 39323e00a2f0abadde12cd31c641c210312674eb Mon Sep 17 00:00:00 2001 From: Owen Jones Date: Tue, 24 Jul 2018 16:43:56 +0100 Subject: [PATCH 2/2] Remove code owners from low-risk files This leaves an empty list, the behaviour of which isn't documented, but experiments show github does not consider anyone to be a code owner for those files and does not automatically request any reviews for them. --- CODEOWNERS | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 33b59528460..32e51645b4a 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -48,12 +48,12 @@ # These files change frequently and changes are low-risk -/src/util/irep_ids.def @diffblue/cbmc-developers +/src/util/irep_ids.def -/unit/ @diffblue/cbmc-developers -/regression/ @diffblue/cbmc-developers -/jbmc/unit/ @diffblue/cbmc-developers -/jbmc/regression/ @diffblue/cbmc-developers +/unit/ +/regression/ +/jbmc/unit/ +/jbmc/regression/ /scripts/ @diffblue/devops @thk123 @forejtv @peterschrammel /.travis.yml @diffblue/devops @thk123 @forejtv @peterschrammel