From 53c90dbd85f59b83ea0178ad11e8cf75a22ca80f Mon Sep 17 00:00:00 2001 From: Owen Jones Date: Thu, 19 Jul 2018 15:05:50 +0100 Subject: [PATCH 1/5] Remove default code owners --- CODEOWNERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index fa575bfb0a6..7b3de6b560c 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,6 +1,3 @@ -# These owners will be the default owners for everything in the repo. -* @kroening @tautschnig @peterschrammel @smowton @chrisr-diffblue - # These files should rarely change src/big-int/ @kroening From 2a84885cb87e855faf4d97bed661eacf748481f7 Mon Sep 17 00:00:00 2001 From: Owen Jones Date: Thu, 19 Jul 2018 17:15:37 +0100 Subject: [PATCH 2/5] Don't use cbmc-developers as a code owner Leave code owners for test folders unspecified --- CODEOWNERS | 9 --------- 1 file changed, 9 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 7b3de6b560c..ad18c4a5ab6 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -43,15 +43,6 @@ jbmc/src/jdiff/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschr src/cpp/ @kroening @tautschnig @peterschrammel -# These files change frequently and changes are low-risk - -src/util/irep_ids.def @diffblue/cbmc-developers - -unit/ @diffblue/cbmc-developers -regression/ @diffblue/cbmc-developers -jbmc/unit/ @diffblue/cbmc-developers -jbmc/regression/ @diffblue/cbmc-developers - scripts/ @diffblue/devops @thk123 @forejtv @peterschrammel .travis.yml @diffblue/devops @thk123 @forejtv @peterschrammel appveyor.yml @diffblue/devops @thk123 @forejtv @peterschrammel From 69e5d9eb58c8692dec7ea73d522694e98a9cd881 Mon Sep 17 00:00:00 2001 From: Owen Jones Date: Thu, 19 Jul 2018 17:03:50 +0100 Subject: [PATCH 3/5] Make directories match from root --- CODEOWNERS | 72 +++++++++++++++++++++++++++--------------------------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index ad18c4a5ab6..2ebe9624df8 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,48 +1,48 @@ # These files should rarely change -src/big-int/ @kroening -src/ansi-c/ @kroening @tautschnig -src/assembler/ @kroening @tautschnig -src/goto-cc/ @kroening @tautschnig -src/linking/ @kroening @tautschnig -src/memory-models/ @kroening @tautschnig -src/goto-symex/ @kroening @tautschnig @peterschrammel -src/json/ @kroening @tautschnig @peterschrammel -src/langapi/ @kroening @tautschnig @peterschrammel -src/xmllang/ @kroening @tautschnig @peterschrammel -src/nonstd/ @smowton @peterschrammel -src/solvers/cvc @martin-cs @kroening -src/solvers/flattening @martin-cs @kroening @tautschnig @peterschrammel -src/solvers/floatbv @martin-cs @kroening -src/solvers/miniBDD @tautschnig @kroening -src/solvers/prop @martin-cs @kroening @tautschnig @peterschrammel -src/solvers/sat @martin-cs @kroening @tautschnig @peterschrammel -src/solvers/smt2 @martin-cs @tautschnig @peterschrammel -jbmc/src/miniz/ @smowton @mgudemann @peterschrammel +/src/big-int/ @kroening +/src/ansi-c/ @kroening @tautschnig +/src/assembler/ @kroening @tautschnig +/src/goto-cc/ @kroening @tautschnig +/src/linking/ @kroening @tautschnig +/src/memory-models/ @kroening @tautschnig +/src/goto-symex/ @kroening @tautschnig @peterschrammel +/src/json/ @kroening @tautschnig @peterschrammel +/src/langapi/ @kroening @tautschnig @peterschrammel +/src/xmllang/ @kroening @tautschnig @peterschrammel +/src/nonstd/ @smowton @peterschrammel +/src/solvers/cvc @martin-cs @kroening +/src/solvers/flattening @martin-cs @kroening @tautschnig @peterschrammel +/src/solvers/floatbv @martin-cs @kroening +/src/solvers/miniBDD @tautschnig @kroening +/src/solvers/prop @martin-cs @kroening @tautschnig @peterschrammel +/src/solvers/sat @martin-cs @kroening @tautschnig @peterschrammel +/src/solvers/smt2 @martin-cs @tautschnig @peterschrammel +/jbmc/src/miniz/ @smowton @mgudemann @peterschrammel # These files change frequently and changes are high-risk -src/cbmc/ @smowton @kroening @tautschnig @peterschrammel -src/goto-programs/ @smowton @kroening @tautschnig @peterschrammel @pkesseli -src/util/ @smowton @kroening @tautschnig @peterschrammel @pkesseli -src/solvers/refinement @martin-cs @romainbrenguier @peterschrammel -jbmc/src/java_bytecode/ @smowton @mgudemann @thk123 @cristina-david @cesaro @pkesseli @NathanJPhillips @peterschrammel -src/analyses/ @martin-cs @peterschrammel @chrisr-diffblue @thk123 @smowton -src/pointer-analysis/ @martin-cs @peterschrammel @chrisr-diffblue @smowton +/src/cbmc/ @smowton @kroening @tautschnig @peterschrammel +/src/goto-programs/ @smowton @kroening @tautschnig @peterschrammel @pkesseli +/src/util/ @smowton @kroening @tautschnig @peterschrammel @pkesseli +/src/solvers/refinement @martin-cs @romainbrenguier @peterschrammel +/jbmc/src/java_bytecode/ @smowton @mgudemann @thk123 @cristina-david @cesaro @pkesseli @NathanJPhillips @peterschrammel +/src/analyses/ @martin-cs @peterschrammel @chrisr-diffblue @thk123 @smowton +/src/pointer-analysis/ @martin-cs @peterschrammel @chrisr-diffblue @smowton # These files change frequently and changes are medium-risk -src/goto-analyzer/ @martin-cs @chrisr-diffblue @peterschrammel -src/goto-instrument/ @martin-cs @chrisr-diffblue @peterschrammel -src/goto-diff/ @tautschnig @peterschrammel -jbmc/src/jbmc/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel -jbmc/src/janalyzer/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel -jbmc/src/jdiff/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel -src/cpp/ @kroening @tautschnig @peterschrammel +/src/goto-analyzer/ @martin-cs @chrisr-diffblue @peterschrammel +/src/goto-instrument/ @martin-cs @chrisr-diffblue @peterschrammel +/src/goto-diff/ @tautschnig @peterschrammel +/jbmc/src/jbmc/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel +/jbmc/src/janalyzer/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel +/jbmc/src/jdiff/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel +/src/cpp/ @kroening @tautschnig @peterschrammel -scripts/ @diffblue/devops @thk123 @forejtv @peterschrammel -.travis.yml @diffblue/devops @thk123 @forejtv @peterschrammel -appveyor.yml @diffblue/devops @thk123 @forejtv @peterschrammel +/scripts/ @diffblue/devops @thk123 @forejtv @peterschrammel +/.travis.yml @diffblue/devops @thk123 @forejtv @peterschrammel +/appveyor.yml @diffblue/devops @thk123 @forejtv @peterschrammel From efe61872b8f215d71fb5a7390db50f75d2df82a2 Mon Sep 17 00:00:00 2001 From: Peter Schrammel Date: Thu, 19 Jul 2018 12:11:56 +0100 Subject: [PATCH 4/5] Remove code owners for low risk files --- CODEOWNERS | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 2ebe9624df8..c59c4448f5c 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -43,6 +43,5 @@ /src/cpp/ @kroening @tautschnig @peterschrammel -/scripts/ @diffblue/devops @thk123 @forejtv @peterschrammel -/.travis.yml @diffblue/devops @thk123 @forejtv @peterschrammel -/appveyor.yml @diffblue/devops @thk123 @forejtv @peterschrammel +# All remaining files are assumed to be low-risk +# Any two reviewers can be assigned From 52d71d2b97f85f67c24a041d71f7ce69e438c8c4 Mon Sep 17 00:00:00 2001 From: Peter Schrammel Date: Thu, 19 Jul 2018 12:38:35 +0100 Subject: [PATCH 5/5] Reduce number of codeowners for frequently changed files to 2 --- CODEOWNERS | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index c59c4448f5c..a757e9246cb 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -23,24 +23,24 @@ # These files change frequently and changes are high-risk -/src/cbmc/ @smowton @kroening @tautschnig @peterschrammel -/src/goto-programs/ @smowton @kroening @tautschnig @peterschrammel @pkesseli -/src/util/ @smowton @kroening @tautschnig @peterschrammel @pkesseli -/src/solvers/refinement @martin-cs @romainbrenguier @peterschrammel -/jbmc/src/java_bytecode/ @smowton @mgudemann @thk123 @cristina-david @cesaro @pkesseli @NathanJPhillips @peterschrammel -/src/analyses/ @martin-cs @peterschrammel @chrisr-diffblue @thk123 @smowton -/src/pointer-analysis/ @martin-cs @peterschrammel @chrisr-diffblue @smowton +/src/cbmc/ @kroening @tautschnig +/src/goto-programs/ @kroening @tautschnig +/src/util/ @kroening @tautschnig +/src/solvers/refinement @romainbrenguier @peterschrammel +/jbmc/src/java_bytecode/ @peterschrammel @smowton +/src/analyses/ @martin-cs @chrisr-diffblue +/src/pointer-analysis/ @smowton @tautschnig # These files change frequently and changes are medium-risk -/src/goto-analyzer/ @martin-cs @chrisr-diffblue @peterschrammel -/src/goto-instrument/ @martin-cs @chrisr-diffblue @peterschrammel -/src/goto-diff/ @tautschnig @peterschrammel -/jbmc/src/jbmc/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel -/jbmc/src/janalyzer/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel -/jbmc/src/jdiff/ @smowton @mgudemann @cristina-david @cesaro @pkesseli @peterschrammel -/src/cpp/ @kroening @tautschnig @peterschrammel +/src/goto-analyzer/ @martin-cs @chrisr-diffblue +/src/goto-instrument/ @martin-cs @chrisr-diffblue +/src/goto-diff/ @peterschrammel @tautschnig +/jbmc/src/jbmc/ @peterschrammel @smowton +/jbmc/src/janalyzer/ @peterschrammel @smowton +/jbmc/src/jdiff/ @peterschrammel @smowton +/src/cpp/ @peterschrammel @tautschnig # All remaining files are assumed to be low-risk