From 85b8d7b187aaa28f74ce19c97686d3d1111d3261 Mon Sep 17 00:00:00 2001 From: Michael Tautschnig Date: Thu, 21 Apr 2016 07:45:49 +0100 Subject: [PATCH] Avoid string contents comparison, perform cheap operation first in || --- src/goto-analyzer/taint_analysis.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/goto-analyzer/taint_analysis.cpp b/src/goto-analyzer/taint_analysis.cpp index 444624851df..eaf66ed8006 100644 --- a/src/goto-analyzer/taint_analysis.cpp +++ b/src/goto-analyzer/taint_analysis.cpp @@ -134,8 +134,8 @@ void taint_analysist::instrument( { bool match=false; for(const auto & i : identifiers) - if(has_prefix(id2string(i), "java::"+id2string(rule.function_identifier)+":") || - id2string(i)==id2string(rule.function_identifier)) + if(i==rule.function_identifier || + has_prefix(id2string(i), "java::"+id2string(rule.function_identifier)+":")) { match=true; break;