Skip to content

Scope of SHARING macro in util/irep.h is too great #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reuk opened this issue May 10, 2017 · 0 comments
Closed

Scope of SHARING macro in util/irep.h is too great #907

reuk opened this issue May 10, 2017 · 0 comments

Comments

@reuk
Copy link
Contributor

reuk commented May 10, 2017

Whether or not irept uses sharing is an implementation detail. Having the SHARING switch in the header means that if I want to disable sharing, I have to rebuild all of CBMC instead of just the irep implementation. Also, this means that SHARING gets defined in every file which includes irep.h, which (as it is not a particularly long name) is likely to collide with another macro or enum identifier at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants