Skip to content

Streamline Makefiles #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
allredj opened this issue Mar 20, 2017 · 5 comments
Closed

Streamline Makefiles #657

allredj opened this issue Mar 20, 2017 · 5 comments

Comments

@allredj
Copy link
Contributor

allredj commented Mar 20, 2017

There should be one filename per line in Makefiles.
Each line should end with an \, even the last one.
A list of lines should thus end with a comment such as:
# Empty last line.

This will make merging of branches much easier.

@thk123
Copy link
Contributor

thk123 commented Mar 20, 2017

See #497 - I've been gradually introducing this approach as I modify make files anyway.

@allredj
Copy link
Contributor Author

allredj commented Mar 20, 2017

That's a good approach. We need to communicate further, as not everyone is aware of these guidelines (e.g. 055f515).
Or else completely rewrite the Makefiles at once.

@martin-cs
Copy link
Collaborator

martin-cs commented Mar 20, 2017 via email

@allredj
Copy link
Contributor Author

allredj commented Mar 20, 2017

It could. Who's in charge of that?

@thk123
Copy link
Contributor

thk123 commented Mar 20, 2017

So in waiting for sprint planning I have finally written said script to sort out make files and updated the linked PR, thanks for nudging me to do this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants