Skip to content

Audit throw 0 instances throughout the code base #6468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaswatPadhi opened this issue Nov 22, 2021 · 1 comment
Open

Audit throw 0 instances throughout the code base #6468

SaswatPadhi opened this issue Nov 22, 2021 · 1 comment
Labels

Comments

@SaswatPadhi
Copy link
Contributor

CBMC version: 516f109

Forking off from @martin-cs's recent comment: #6249 (comment)

We use the throw 0 at several places throughout code base. We should use audit these instances and:

  1. check if it would be more appropriate to raise an INVARIANT violation,
  2. throw exceptions or at least std::strings in place of 0
@NlightNFotis
Copy link
Contributor

I'm all for this (and would be happy to assist with that effort myself).

We had already done a round of this, around 2018-2019, and we have removed most (all?) of the throw 0;s in some folders, but of course I've seen more of them get introduced over time, and we didn't get through all the project subfolders the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants