Skip to content

Replace all uses of type_eq by base_type_eq #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tautschnig opened this issue Aug 22, 2018 · 1 comment
Closed

Replace all uses of type_eq by base_type_eq #2808

tautschnig opened this issue Aug 22, 2018 · 1 comment

Comments

@tautschnig
Copy link
Collaborator

It holds that type_eq(t1, t2, ns) implies base_type_eq(t1, t2, ns), but the converse isn't necessarily true (if expansion of symbol types isn't consistent between t1 and t2). This distinction, however, is subtle and only comes with a some (not measured) performance benefit. Maintaining two functions doing almost the same is painful and confusing.

In the medium term, neither type_eq nor base_type_eq should be necessary as tag types ought to enable use of operator== as the one and only equality comparison over types.

@tautschnig
Copy link
Collaborator Author

type_eq has been removed in #4304.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant