Skip to content

Fix temporarily invalid instructions in goto convert #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterschrammel opened this issue Jun 15, 2018 · 1 comment
Closed

Fix temporarily invalid instructions in goto convert #2357

peterschrammel opened this issue Jun 15, 2018 · 1 comment

Comments

@peterschrammel
Copy link
Member

peterschrammel commented Jun 15, 2018

See #2356 for the context

A couple of initial suggestions to fix this:

  1. Use an explicit dummy target to be passed to make_goto()
    • very simple
    • helps avoiding wrongly incomplete initialisations
    • allows checking that a converted goto program does not have incompletely initialised instructions
  2. Refactor goto_convert to perform single-step initialisation of goto instructions
    • quite some work
  3. Keep NO_INSTRUCTION_TYPE and move if-then-else optimisation into a goto pass
    • doable, but doesn't feel right
    • makes invalid instructions explicit and the absence of incompletely initialised instructions can be easily checked
  4. ?

In any case also https://github.com/diffblue/cbmc/blob/develop/src/goto-programs/goto_program.h#L495 should be removed.

@tautschnig
Copy link
Collaborator

Fixed via #2361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants