Skip to content

Add additional regression tests for --replace-function-body #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hannes-steffenhagen-diffblue opened this issue Mar 19, 2018 · 3 comments

Comments

@hannes-steffenhagen-diffblue
Copy link
Contributor

As per @thk123 s comments on #1889 there are some additional edge cases which we should be testing for, for instance pointer-to-pointer-to-const.

@martin-cs
Copy link
Collaborator

Particular horrors are the difference between 'const int *' 'int * const' 'const int * const' and structures (and unions?) with some const fields and some non-const ones.

@hannes-steffenhagen-diffblue
Copy link
Contributor Author

hannes-steffenhagen-diffblue commented Mar 21, 2018

@martin-cs What should the behaviour in that case be? Just refuse to assign, or assign to all non-const fields manually?

EDIT referring to structs with a mix of constant and non-constant members

@martin-cs
Copy link
Collaborator

@hannes-steffenhagen-diffblue I'm not sure I have one fixed answer in mind; just as long as there is a consistent, correct and justifiable answer. Throwing an error, assigning all non-const fields (possibly with a warning), assigning everything (with a warning), these all seem possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants