Skip to content

CBMC-cover tests fail due to an invariant violation #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reuk opened this issue Nov 24, 2017 · 1 comment
Closed

CBMC-cover tests fail due to an invariant violation #1622

reuk opened this issue Nov 24, 2017 · 1 comment

Comments

@reuk
Copy link
Contributor

reuk commented Nov 24, 2017

While working on #1612, I found an error in goto-instrument/cover.cpp. The problem is that the begin() of an empty vector is dereferenced, leading to undefined behavior.

Adding an invariant to ensure the vector has at least one element causes several tests in cbmc-cover to fail. These tests have been disabled in this commit.

The original author of the code appears to be @theyoucheng, so I suggest that they are assigned to fix this problem. The result of the fix should be that the failing tests are re-enabled.

@martin-cs
Copy link
Collaborator

Thanks @reuk for the informative summary.

@theyoucheng : please could you have a look at these, we really shouldn't have obvious code inputs which trigger invariant failures.

@peterschrammel might also be interested in this as he was refactoring some of the coverage code at one point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants