Add abstract_object::write_location_context

Default implementation just forwards to update_location_context({from}, true)

Author: jezhiggins

src/analyses/variable-sensitivity/abstract_object.cpp

@@ -241,6 +241,12 @@ bool abstract_objectt::should_use_base_meet(
   return is_bottom() || is_top() || other->is_bottom() || other->is_top();
 }
 
+abstract_object_pointert
+abstract_objectt::write_location_context(const locationt &location) const
+{
+  return update_location_context({location}, true);
+}
+
 abstract_object_pointert abstract_objectt::update_location_context(
   const locationst &locations,
   const bool update_sub_elements) const

src/analyses/variable-sensitivity/abstract_object.h

@@ -289,6 +289,9 @@ class abstract_objectt : public std::enable_shared_from_this<abstract_objectt>
   virtual abstract_object_pointert
   meet(const abstract_object_pointert &other) const;
 
+  virtual abstract_object_pointert
+  write_location_context(const locationt &location) const;
+
   /**
    * Update the location context for an abstract object, potentially
    * propogating the update to any children of this abstract object.

src/analyses/variable-sensitivity/variable_sensitivity_domain.cpp

@@ -39,12 +39,11 @@ void variable_sensitivity_domaint::transform(
   {
   case DECL:
   {
-    const abstract_objectt::locationst write_location = {from};
     abstract_object_pointert top_object =
       abstract_state
         .abstract_object_factory(
           instruction.decl_symbol().type(), ns, true, false)
-        ->update_location_context(write_location, true);
+        ->write_location_context(from);
     abstract_state.assign(instruction.decl_symbol(), top_object, ns);
   }
   // We now store top.
@@ -60,10 +59,8 @@ void variable_sensitivity_domaint::transform(
   {
     // TODO : check return values
     const code_assignt &inst = instruction.get_assign();
-    const abstract_objectt::locationst write_location = {from};
     abstract_object_pointert rhs =
-      abstract_state.eval(inst.rhs(), ns)
-        ->update_location_context(write_location, true);
+      abstract_state.eval(inst.rhs(), ns)->write_location_context(from);
     abstract_state.assign(inst.lhs(), rhs, ns);
   }
   break;
@@ -382,8 +379,7 @@ void variable_sensitivity_domaint::transform_function_call(
         // Evaluate the expression that is being
         // passed into the function call (called_arg)
         abstract_object_pointert param_val =
-          abstract_state.eval(called_arg, ns)
-            ->update_location_context({from}, true);
+          abstract_state.eval(called_arg, ns)->write_location_context(from);
 
         // Assign the evaluated value to the symbol associated with the
         // parameter of the function