Tidy up full_lhs_value

Thomas Kiley · peterschrammel · Thomas Kiley · commit e57e194b7e50 · 2020-05-06T10:24:24.000+01:00
Applied modern coding standards to pulled out code

Co-authored-by: Peter Schrammel &lt;peterschrammel@users.noreply.github.com&gt;
diff --git a/src/goto-programs/xml_goto_trace.cpp b/src/goto-programs/xml_goto_trace.cpp
@@ -27,8 +27,8 @@ xmlt full_lhs_value(const goto_trace_stept &step, const namespacet &ns)
 {
   xmlt full_lhs_value{"full_lhs_value"};
 
-  auto lhs_object = step.get_lhs_object();
-  irep_idt identifier =
+  const auto &lhs_object = step.get_lhs_object();
+  const irep_idt identifier =
     lhs_object.has_value() ? lhs_object->get_identifier() : irep_idt();
 
   if(step.full_lhs_value.is_not_nil())

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,8 @@ xmlt full_lhs_value(const goto_trace_stept &step, const namespacet &ns)`
`27`	`27`	`{`
`28`	`28`	`xmlt full_lhs_value{"full_lhs_value"};`
`29`	`29`
`30`		`- auto lhs_object = step.get_lhs_object();`
`31`		`- irep_idt identifier =`
	`30`	`+ const auto &lhs_object = step.get_lhs_object();`
	`31`	`+ const irep_idt identifier =`
`32`	`32`	`lhs_object.has_value() ? lhs_object->get_identifier() : irep_idt();`
`33`	`33`
`34`	`34`	`if(step.full_lhs_value.is_not_nil())`