use unary_exprt::op() instead of op0()

This will eventually allow us to protect exprt::opX().

Author: Daniel Kroening

jbmc/src/java_bytecode/java_bytecode_instrument.cpp

@@ -525,10 +525,8 @@ optionalt<codet> java_bytecode_instrumentt::instrument_expr(const exprt &expr)
   {
     // Check pointer non-null before access:
     const dereference_exprt &dereference_expr = to_dereference_expr(expr);
-    codet null_dereference_check=
-      check_null_dereference(
-        dereference_expr.op0(),
-        dereference_expr.source_location());
+    codet null_dereference_check = check_null_dereference(
+      dereference_expr.pointer(), dereference_expr.source_location());
     result.add(std::move(null_dereference_check));
   }
 

jbmc/unit/java_bytecode/java_bytecode_convert_method/convert_invoke_dynamic.cpp

@@ -53,8 +53,7 @@ void validate_lambda_assignment(
   const typecast_exprt &rhs_value =
     require_expr::require_typecast(lambda_assignment.rhs());
 
-  const symbol_exprt &rhs_symbol =
-    require_expr::require_symbol(rhs_value.op0());
+  const symbol_exprt &rhs_symbol = require_expr::require_symbol(rhs_value.op());
 
   const irep_idt &tmp_object_symbol = rhs_symbol.get_identifier();
 

src/goto-programs/remove_complex.cpp

@@ -217,11 +217,11 @@ static void remove_complex(exprt &expr)
 
   if(expr.id()==ID_complex_real)
   {
-    expr = complex_member(to_complex_real_expr(expr).op0(), ID_real);
+    expr = complex_member(to_complex_real_expr(expr).op(), ID_real);
   }
   else if(expr.id()==ID_complex_imag)
   {
-    expr = complex_member(to_complex_imag_expr(expr).op0(), ID_imag);
+    expr = complex_member(to_complex_imag_expr(expr).op(), ID_imag);
   }
 
   remove_complex(expr.type());

src/goto-programs/remove_vector.cpp

@@ -132,7 +132,7 @@ static void remove_vector(exprt &expr)
         exprt index=from_integer(i, array_type.size().type());
 
         array_expr.operands()[i] = unary_exprt(
-          unary_expr.id(), index_exprt(unary_expr.op0(), index, subtype));
+          unary_expr.id(), index_exprt(unary_expr.op(), index, subtype));
       }
 
       expr=array_expr;

src/solvers/flattening/boolbv_union.cpp

@@ -46,7 +46,7 @@ bvt boolbvt::convert_union(const union_exprt &expr)
       "endianness should be set to either little endian or big endian");
 
     bv_endianness_mapt map_u(expr.type(), false, ns, boolbv_width);
-    bv_endianness_mapt map_op(expr.op0().type(), false, ns, boolbv_width);
+    bv_endianness_mapt map_op(expr.op().type(), false, ns, boolbv_width);
 
     for(std::size_t i=0; i<op_bv.size(); i++)
       bv[map_u.map_bit(i)]=op_bv[map_op.map_bit(i)];

src/util/simplify_expr.cpp

@@ -242,7 +242,7 @@ bool simplify_exprt::simplify_typecast(exprt &expr)
       const auto &typecast=expr_checked_cast<typecast_exprt>(expr.op0());
       if(typecast.op().type()==expr_type)
       {
-        expr=typecast.op0();
+        expr = typecast.op();
         return false;
       }
     }