Actually test linker script processing

The goto-cc personality does not invoke linker script processing, hence
the tests located in the ansi-c folder were a no-op. Moving them to the
goto-gcc folder showed that they wouldn't work as is, which is also
fixed now:

1) Add -Wl,--no-dynamic-linker so as not to generate dynamic linking
headers, which those linker scripts leave no room for.
2) Actually detect failure of linker script parsing by enabling warnings
and testing for them.
3) Make sure ls_parse.py is available on the PATH.
4) Linker scripts aren't supported by Apple's linker.

Author: tautschnig

regression/goto-gcc/CMakeLists.txt

@@ -15,3 +15,11 @@ add_custom_command(OUTPUT "${CMAKE_CURRENT_SOURCE_DIR}/archives/libour_archive.a
 add_custom_target(libour_archive.a ALL
     DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/archives/libour_archive.a"
 )
+
+if(NOT "${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
+  set_property(
+    TEST "goto-gcc-CORE"
+    PROPERTY ENVIRONMENT
+      "PATH=$ENV{PATH}:$<TARGET_FILE_DIR:goto-cc>"
+  )
+endif()

regression/goto-gcc/Makefile

@@ -10,10 +10,10 @@ tests.log: ../test.pl
 
 else
 test: ../../src/goto-cc/goto-gcc
-	@../test.pl -e -p -c ../../../src/goto-cc/goto-gcc
+	@PATH=../../../scripts:$$PATH ../test.pl -e -p -c ../../../src/goto-cc/goto-gcc
 
 tests.log: ../test.pl ../../src/goto-cc/goto-gcc
-	@../test.pl -e -p -c ../../../src/goto-cc/goto-gcc
+	@PATH=../../../scripts:$$PATH ../test.pl -e -p -c ../../../src/goto-cc/goto-gcc
 
 ../../src/goto-cc/goto-gcc: ../../src/goto-cc/goto-cc
 	@ln -sf goto-cc ../../src/goto-cc/goto-gcc

regression/ansi-c/linker_script_start+end/main.c renamed to regression/goto-gcc/linker_script_start+end/main.c

@@ -2,11 +2,13 @@ extern char src_start[];
 extern char src_end[];
 extern char dst_start[];
 
-void *memcpy(void *dest, void *src, unsigned n){
+void *memcpy(void *dest, void *src, unsigned n)
+{
   return (void *)0;
 }
 
-int main(){
+int main()
+{
   memcpy(dst_start, src_start, (unsigned)src_end - (unsigned)src_start);
   return 0;
 }

regression/ansi-c/linker_script_start+end/script.ld renamed to regression/goto-gcc/linker_script_start+end/script.ld

@@ -1,9 +1,10 @@
 CORE
 main.c
--o out.gb -T script.ld -nostdlib
+-o out.gb -T script.ld -nostdlib -Wl,--no-dynamic-linker -Wall
 ^EXIT=0$
 ^SIGNAL=0$
 --
+Problem parsing linker script
 ^warning: ignoring
 ^CONVERSION ERROR$
 --

regression/ansi-c/linker_script_start+end/test.desc renamed to regression/goto-gcc/linker_script_start+end/test.desc

@@ -2,11 +2,13 @@ extern char src_start[];
 extern char src_size[];
 extern char dst_start[];
 
-void *memcpy(void *dest, void *src, unsigned n){
+void *memcpy(void *dest, void *src, unsigned n)
+{
   return (void *)0;
 }
 
-int main(){
+int main()
+{
   memcpy(dst_start, src_start, (unsigned)src_size);
   return 0;
 }

regression/ansi-c/linker_script_start+size/main.c renamed to regression/goto-gcc/linker_script_start+size/main.c

@@ -1,9 +1,10 @@
 CORE
 main.c
--o out.gb -T script.ld -nostdlib
+-o out.gb -T script.ld -nostdlib -Wl,--no-dynamic-linker -Wall
 ^EXIT=0$
 ^SIGNAL=0$
 --
+Problem parsing linker script
 ^warning: ignoring
 ^CONVERSION ERROR$
 --

regression/ansi-c/linker_script_start+size/script.ld renamed to regression/goto-gcc/linker_script_start+size/script.ld

@@ -1,6 +1,7 @@
 extern char sym[];
 
-int main(){
+int main()
+{
   int foo = (int)sym;
   return 0;
 }

regression/ansi-c/linker_script_start+size/test.desc renamed to regression/goto-gcc/linker_script_start+size/test.desc

@@ -1,9 +1,10 @@
 CORE
 main.c
--o out.gb -T script.ld -nostdlib
+-o out.gb -T script.ld -nostdlib -Wl,--no-dynamic-linker -Wall
 ^EXIT=0$
 ^SIGNAL=0$
 --
+Problem parsing linker script
 ^warning: ignoring
 ^CONVERSION ERROR$
 --

regression/ansi-c/linker_script_symbol-only/main.c renamed to regression/goto-gcc/linker_script_symbol-only/main.c

@@ -41,11 +41,18 @@ else()
     COMMAND "${CMAKE_COMMAND}" -E create_symlink
       goto-cc $<TARGET_FILE_DIR:goto-cc>/goto-ld
     BYPRODUCTS ${CMAKE_BINARY_DIR}/bin/goto-ld)
+  add_custom_command(TARGET goto-cc
+    POST_BUILD
+    COMMAND "${CMAKE_COMMAND}" -E copy
+      ${CMAKE_CURRENT_SOURCE_DIR}/../../scripts/ls_parse.py
+      $<TARGET_FILE_DIR:goto-cc>/ls_parse.py
+    BYPRODUCTS ${CMAKE_BINARY_DIR}/bin/ls_parse.py)
 
   install(
     FILES
       ${CMAKE_BINARY_DIR}/bin/goto-ld
       ${CMAKE_BINARY_DIR}/bin/goto-gcc
+      ${CMAKE_BINARY_DIR}/bin/ls_parse.py
     DESTINATION
       ${CMAKE_INSTALL_BINDIR})
 endif()

regression/ansi-c/linker_script_symbol-only/script.ld renamed to regression/goto-gcc/linker_script_symbol-only/script.ld

@@ -958,6 +958,7 @@ int gcc_modet::gcc_hybrid_binary(compilet &compiler)
 
   int result=run_gcc(compiler);
 
+#if defined(__linux__) || defined(__FreeBSD_kernel__) || defined(__OpenBSD__)
   if(result==0 &&
      cmdline.isset('T') &&
      goto_binaries.size()==1 &&
@@ -970,6 +971,7 @@ int gcc_modet::gcc_hybrid_binary(compilet &compiler)
       gcc_message_handler);
     result=ls_merge.add_linker_script_definitions();
   }
+#endif
 
   std::string native_tool;