Merge pull request #7368 from remi-delmas-3000/typed_target-typechecking-fix

tautschnig · web-flow · commit dbe55578a1eb · 2022-11-22T22:05:01.000+01:00
CONTRACTS: dont typecheck typed_target operands twice
diff --git a/src/ansi-c/c_typecheck_expr.cpp b/src/ansi-c/c_typecheck_expr.cpp
@@ -1944,7 +1944,7 @@ void c_typecheck_baset::typecheck_typed_target_call(
   }
 
   auto arg0 = expr.arguments().front();
-  typecheck_expr(arg0);
+
   if(!is_assignable(arg0) || !arg0.get_bool(ID_C_lvalue))
   {
     throw invalid_source_file_exceptiont{
@@ -1976,7 +1976,7 @@ void c_typecheck_baset::typecheck_typed_target_call(
     arguments.push_back(false_exprt());
 
   expr.arguments().swap(arguments);
-  typecheck_side_effect_function_call(expr);
+  expr.type() = empty_typet();
 }
 
 void c_typecheck_baset::typecheck_side_effect_function_call(

Original file line number	Diff line number	Diff line change
`@@ -1944,7 +1944,7 @@ void c_typecheck_baset::typecheck_typed_target_call(`
`1944`	`1944`	`}`
`1945`	`1945`
`1946`	`1946`	`auto arg0 = expr.arguments().front();`
`1947`		`- typecheck_expr(arg0);`
	`1947`	`+`
`1948`	`1948`	`if(!is_assignable(arg0) \|\| !arg0.get_bool(ID_C_lvalue))`
`1949`	`1949`	`{`
`1950`	`1950`	`throw invalid_source_file_exceptiont{`
`@@ -1976,7 +1976,7 @@ void c_typecheck_baset::typecheck_typed_target_call(`
`1976`	`1976`	`arguments.push_back(false_exprt());`
`1977`	`1977`
`1978`	`1978`	`expr.arguments().swap(arguments);`
`1979`		`- typecheck_side_effect_function_call(expr);`
	`1979`	`+ expr.type() = empty_typet();`
`1980`	`1980`	`}`
`1981`	`1981`
`1982`	`1982`	`void c_typecheck_baset::typecheck_side_effect_function_call(`