Construct equal_exprt in a non-deprecated way

The default constructor is deprecated.

Author: tautschnig

src/analyses/invariant_set.cpp

@@ -753,9 +753,8 @@ void invariant_sett::nnf(exprt &expr, bool negate)
       typecast_expr.op().type().id() == ID_unsignedbv ||
       typecast_expr.op().type().id() == ID_signedbv)
     {
-      equal_exprt tmp;
-      tmp.lhs() = typecast_expr.op();
-      tmp.rhs() = from_integer(0, typecast_expr.op().type());
+      equal_exprt tmp(
+        typecast_expr.op(), from_integer(0, typecast_expr.op().type()));
       nnf(tmp, !negate);
       expr.swap(tmp);
     }
@@ -1054,9 +1053,7 @@ void invariant_sett::assignment(
   const exprt &lhs,
   const exprt &rhs)
 {
-  equal_exprt equality;
-  equality.lhs()=lhs;
-  equality.rhs()=rhs;
+  equal_exprt equality(lhs, rhs);
 
   // first evaluate RHS
   simplify(equality.rhs());

src/ansi-c/c_typecheck_expr.cpp

@@ -2544,8 +2544,7 @@ exprt c_typecheck_baset::do_special_functions(
       throw 0;
     }
 
-    equal_exprt equality_expr;
-    equality_expr.operands()=expr.arguments();
+    equal_exprt equality_expr(expr.arguments().front(), expr.arguments().back());
     equality_expr.add_source_location()=source_location;
 
     if(!base_type_eq(equality_expr.lhs().type(),

src/goto-programs/goto_convert.cpp

@@ -1156,9 +1156,7 @@ exprt goto_convertt::case_guard(
 
     forall_expr(it, case_op)
     {
-      equal_exprt eq_expr;
-      eq_expr.lhs() = value;
-      eq_expr.rhs() = *it;
+      equal_exprt eq_expr(value, *it);
       dest.move_to_operands(eq_expr);
     }
     INVARIANT(

src/solvers/flattening/boolbv_byte_extract.cpp

@@ -143,8 +143,8 @@ bvt boolbvt::convert_byte_extract(const byte_extract_exprt &expr)
 
       // add implications
 
-      equal_exprt equality;
-      equality.lhs() = expr.offset(); // index operand
+      // index operand
+      equal_exprt equality(expr.offset(), exprt());
 
       // type of index operand
       const typet &constant_type = expr.offset().type();
@@ -170,8 +170,8 @@ bvt boolbvt::convert_byte_extract(const byte_extract_exprt &expr)
     }
     else
     {
-      equal_exprt equality;
-      equality.lhs() = expr.offset(); // index operand
+      // index operand
+      equal_exprt equality(expr.offset(), exprt());
 
       // type of index operand
       const typet &constant_type = expr.offset().type();

src/solvers/flattening/boolbv_byte_update.cpp

@@ -85,9 +85,8 @@ bvt boolbvt::convert_byte_update(const byte_update_exprt &expr)
   for(std::size_t offset=0; offset<bv.size(); offset+=byte_width)
   {
     // index condition
-    equal_exprt equality;
-    equality.lhs()=offset_expr;
-    equality.rhs()=from_integer(offset/byte_width, offset_expr.type());
+    equal_exprt equality(
+      offset_expr, from_integer(offset / byte_width, offset_expr.type()));
     literalt equal=convert(equality);
 
     bv_endianness_mapt map_op(op.type(), little_endian, ns, boolbv_width);

src/solvers/flattening/boolbv_extractbit.cpp

@@ -51,11 +51,8 @@ literalt boolbvt::convert_extractbit(const extractbit_exprt &expr)
       std::max(address_bits(src_bv_width), index_bv_width);
     unsignedbv_typet index_type(index_width);
 
-    equal_exprt equality;
-    equality.lhs() = expr.index();
-
-    if(index_type!=equality.lhs().type())
-      equality.lhs().make_typecast(index_type);
+    equal_exprt equality(
+      typecast_exprt::conditional_cast(expr.index(), index_type), exprt());
 
     if(prop.has_set_to())
     {

src/solvers/flattening/boolbv_index.cpp

@@ -144,11 +144,10 @@ bvt boolbvt::convert_index(const index_exprt &expr)
 
       // add implications
 
-      equal_exprt index_equality;
-      index_equality.lhs()=index; // index operand
+      // index operand
+      equal_exprt index_equality(index, exprt());
 
-      equal_exprt value_equality;
-      value_equality.lhs()=result;
+      equal_exprt value_equality(result, exprt());
 
 #ifdef COMPACT_EQUAL_CONST
       bv_utils.equal_const_register(convert_bv(index));  // Definitely
@@ -203,8 +202,8 @@ bvt boolbvt::convert_index(const index_exprt &expr)
 
       // add implications
 
-      equal_exprt index_equality;
-      index_equality.lhs()=index; // index operand
+      // index operand
+      equal_exprt index_equality(index, exprt());
 
 #ifdef COMPACT_EQUAL_CONST
       bv_utils.equal_const_register(convert_bv(index));  // Definitely
@@ -232,8 +231,8 @@ bvt boolbvt::convert_index(const index_exprt &expr)
     {
       bv.resize(width);
 
-      equal_exprt equality;
-      equality.lhs()=index; // index operand
+      // index operand
+      equal_exprt equality(index, exprt());
 
 #ifdef COMPACT_EQUAL_CONST
       bv_utils.equal_const_register(convert_bv(index));  // Definitely