Merge pull request #4179 from diffblue/extend_make_X_API

extend make_assignment and make_function_call APIs

Author: tautschnig

src/goto-programs/goto_program.h

@@ -959,26 +959,52 @@ class goto_programt
       {_target});
   }
 
+  /// Create an assignment instruction
   static instructiont make_assignment(
     const code_assignt &_code,
     const source_locationt &l = source_locationt::nil())
   {
     return instructiont(_code, l, ASSIGN, nil_exprt(), {});
   }
 
+  /// Create an assignment instruction
+  static instructiont make_assignment(
+    exprt lhs,
+    exprt rhs,
+    const source_locationt &l = source_locationt::nil())
+  {
+    return instructiont(
+      code_assignt(std::move(lhs), std::move(rhs)), l, ASSIGN, nil_exprt(), {});
+  }
+
   static instructiont make_decl(
     const code_declt &_code,
     const source_locationt &l = source_locationt::nil())
   {
     return instructiont(_code, l, DECL, nil_exprt(), {});
   }
 
+  /// Create a function call instruction
   static instructiont make_function_call(
     const code_function_callt &_code,
     const source_locationt &l = source_locationt::nil())
   {
     return instructiont(_code, l, FUNCTION_CALL, nil_exprt(), {});
   }
+
+  /// Create a function call instruction
+  static instructiont make_function_call(
+    exprt function,
+    code_function_callt::argumentst arguments,
+    const source_locationt &l = source_locationt::nil())
+  {
+    return instructiont(
+      code_function_callt(std::move(function), std::move(arguments)),
+      l,
+      FUNCTION_CALL,
+      nil_exprt(),
+      {});
+  }
 };
 
 /// Get control-flow successors of a given instruction. The instruction is