Skip to content

Commit d2baea5

Browse files
Remove comment made unecessary
Now the log field gets initialized before parse_options_baset is constructed so there is no danger as described in the comment.
1 parent 37873f3 commit d2baea5

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

src/util/parse_options.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,6 @@ parse_options_baset::parse_options_baset(
3434
parse_result=cmdline.parse(argc, argv, optstring.c_str());
3535
message_handler = util_make_unique<ui_message_handlert>(cmdline, program);
3636
log = messaget{*message_handler};
37-
38-
// DO NOT USE log HERE!
39-
//
40-
// The usual pattern of use is that the application class inherits from
41-
// messaget and parse_options_baset using a member variable of type
42-
// message_handlert to construct the messaget part.
43-
//
44-
// C++'s rules of initialisation mean that the constructors for
45-
// messaget and then parse_options_base run before those of message_handlert.
46-
// This means that the message_handlert object is uninitialised.
47-
// Using it here will likely cause a hard to debug failure somewhere in
48-
// the messaget code.
4937
}
5038

5139
void parse_options_baset::help()

0 commit comments

Comments
 (0)