Merge pull request #6358 from NlightNFotis/fix_windows_release_arg_order

NlightNFotis · web-flow · commit cdaa7a1e81d0 · 2021-09-22T14:43:23.000+01:00
[CI] Change order of arguments to `signtool.exe`.
diff --git a/.github/workflows/release-packages.yaml b/.github/workflows/release-packages.yaml
@@ -207,7 +207,7 @@ jobs:
           $servers = @('http://ts.ssl.com', 'http://timestamp.digicert.com', 'http://timestamp.sectigo.com')
           foreach($ts_server in $servers)
           {
-            & signtool.exe sign /f $env:pfxcert /p "${{ secrets.CODESIGNCERTPASSWORD }}" /tr $ts_server ${{ steps.create_packages.outputs.msi_installer }} /td SHA256 /fd SHA256
+            & signtool.exe sign /f $env:pfxcert /p "${{ secrets.CODESIGNCERTPASSWORD }}" /tr $ts_server /td SHA256 /fd SHA256 ${{ steps.create_packages.outputs.msi_installer }}
             if ($LastExitCode -eq "0")
             {
               # Stop if code-signing the binary using this server was successful.

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ jobs:`
`207`	`207`	`$servers = @('http://ts.ssl.com', 'http://timestamp.digicert.com', 'http://timestamp.sectigo.com')`
`208`	`208`	`foreach($ts_server in $servers)`
`209`	`209`	`{`
`210`		`- & signtool.exe sign /f $env:pfxcert /p "${{ secrets.CODESIGNCERTPASSWORD }}" /tr $ts_server ${{ steps.create_packages.outputs.msi_installer }} /td SHA256 /fd SHA256`
	`210`	`+ & signtool.exe sign /f $env:pfxcert /p "${{ secrets.CODESIGNCERTPASSWORD }}" /tr $ts_server /td SHA256 /fd SHA256 ${{ steps.create_packages.outputs.msi_installer }}`
`211`	`211`	`if ($LastExitCode -eq "0")`
`212`	`212`	`{`
`213`	`213`	`# Stop if code-signing the binary using this server was successful.`