Lint value-sets

Author: smowton

src/pointer-analysis/value_set.cpp

@@ -1062,17 +1062,20 @@ void value_sett::get_reference_set(
     dest.push_back(to_expr(it));
 }
 
-static void strip_casts(exprt& e, const namespacet& ns, const typet& target_type_raw)
+static void strip_casts(
+  exprt &e,
+  const namespacet &ns,
+  const typet &target_type_raw)
 {
-  const auto& target_type=ns.follow(target_type_raw);
+  const auto &target_type=ns.follow(target_type_raw);
   while(true)
   {
     if(e.id()==ID_typecast)
       e=e.op0();
     else if(e.id()==ID_member)
     {
-      auto& mem=to_member_expr(e);
-      const auto& struct_type=to_struct_type(ns.follow(e.op0().type()));
+      auto &mem=to_member_expr(e);
+      const auto &struct_type=to_struct_type(ns.follow(e.op0().type()));
       if(mem.get_component_name()==struct_type.components()[0].get_name())
         e=e.op0();
       else
@@ -1234,7 +1237,7 @@ void value_sett::get_reference_set_rec(
           {
             // Avoid an infinite loop of casting by stripping typecasts
             // and address-of-first-members first.
-            strip_casts(member_expr.op0(),ns,struct_op.type());
+            strip_casts(member_expr.op0(), ns, struct_op.type());
             if(ns.follow(member_expr.op0().type())!=ns.follow(struct_op.type()))
             member_expr.op0().make_typecast(struct_op.type());
           }

src/pointer-analysis/value_set.h

@@ -113,7 +113,10 @@ class value_sett
     {
     }
 
-    entryt(const idt &_identifier, const std::string &_suffix, const typet &_declared_on_type):
+    entryt(
+      const idt &_identifier,
+      const std::string &_suffix,
+      const typet &_declared_on_type):
       identifier(_identifier),
       suffix(_suffix),
       declared_on_type(_declared_on_type)

src/pointer-analysis/value_set_domain.h

@@ -63,7 +63,9 @@ class value_set_domaint:public domain_baset
       break;
 
     case END_FUNCTION:
-      value_set.do_end_function(static_analysis_baset::get_return_lhs(to_l), ns);
+      value_set.do_end_function(
+        static_analysis_baset::get_return_lhs(to_l),
+        ns);
       break;
 
     case RETURN: