Add a unit test for checking the ordering by instruction

Author: thk123

unit/Makefile

@@ -16,6 +16,7 @@ SRC += analyses/ai/ai.cpp \
        analyses/does_remove_const/is_type_at_least_as_const_as.cpp \
        big-int/big-int.cpp \
        compound_block_locations.cpp \
+       goto-checker/report_util/is_property_less_than.cpp \
        goto-instrument/cover_instrument.cpp \
        goto-instrument/cover/cover_only.cpp \
        goto-programs/goto_model_function_type_consistency.cpp \

unit/goto-checker/report_util/is_property_less_than.cpp

@@ -0,0 +1,72 @@
+// Copyright 2016-2020 Diffblue Limited. All Rights Reserved.
+
+#include <goto-checker/report_util.cpp>
+#include <testing-utils/use_catch.h>
+
+static goto_programt::instructiont instruction_for_location(
+  const irep_idt &file,
+  const irep_idt &function,
+  size_t line_no)
+{
+  source_locationt location;
+  location.set_file(file);
+  location.set_function(function);
+  location.set_line(line_no);
+  goto_programt::instructiont instruction;
+  instruction.source_location = location;
+  return instruction;
+}
+
+static property_infot test_info(const goto_programt::const_targett &target)
+{
+  return property_infot(target, "ignored", property_statust::UNKNOWN);
+}
+
+static propertyt
+property(const irep_idt &identifier, const property_infot &info)
+{
+  return std::make_pair(identifier, info);
+}
+
+std::ostream &operator<<(std::ostream &os, const propertyt &value)
+{
+  os << "{ property_id=" << value.first << ", "
+     << " property_location={ "
+     << " file=" << value.second.pc->source_location.get_file() << ", "
+     << " function=" << value.second.pc->source_location.get_function() << ", "
+     << " line=" << value.second.pc->source_location.get_line() << "}}";
+  return os;
+}
+
+TEST_CASE("Comparing two properties")
+{
+  SECTION("Compare locations")
+  {
+    goto_programt::instructionst instructions;
+    instructions.push_back(instruction_for_location("fileA", "funcA", 1));
+    instructions.push_back(instruction_for_location("fileA", "funcA", 2));
+    instructions.push_back(instruction_for_location("fileA", "funcB", 1));
+    instructions.push_back(instruction_for_location("fileA", "funcB", 2));
+    instructions.push_back(instruction_for_location("fileB", "funcA", 1));
+    instructions.push_back(instruction_for_location("fileB", "funcA", 2));
+    instructions.push_back(instruction_for_location("fileB", "funcB", 1));
+    instructions.push_back(instruction_for_location("fileB", "funcB", 2));
+
+    for(auto first_location = instructions.begin();
+        first_location != instructions.end();
+        ++first_location)
+    {
+      for(auto second_location = std::next(first_location);
+          second_location != instructions.end();
+          ++second_location)
+      {
+        const propertyt p1 = property("ignored", test_info(first_location));
+        const propertyt p2 = property("ignored", test_info(second_location));
+        INFO(p1);
+        INFO(p2);
+        REQUIRE(is_property_less_than(p1, p2));
+        REQUIRE_FALSE(is_property_less_than(p2, p1));
+      }
+    }
+  }
+}

unit/goto-checker/report_util/module_dependencies.txt

@@ -0,0 +1,2 @@
+goto-checker
+testing-utils