Remove unnecessary copy and loss of state information

This commit removes an inline constructor that performed
a copy of the state and thus could cause state information
to be lost.

Author: TGWDB

src/goto-symex/goto_state.h

@@ -20,6 +20,10 @@ Author: Romain Brenguier, [email protected]
 
 #include "renaming_level.h"
 
+// Forward declaration required since subclass is used explicitly
+// by the parent class.
+class goto_symex_statet;
+
 /// Container for data that varies per program point, e.g. the constant
 /// propagator state, when state needs to branch. This is copied out of
 /// goto_symex_statet at a control-flow fork and then back into it at a
@@ -83,8 +87,6 @@ class goto_statet
   goto_statet(const goto_statet &other) = default;
   goto_statet(goto_statet &&other) = default;
 
-  explicit goto_statet(const class goto_symex_statet &s);
-
   explicit goto_statet(guard_managert &guard_manager)
     : guard(true_exprt(), guard_manager), reachable(true)
   {

src/goto-symex/goto_symex_state.h

@@ -272,15 +272,4 @@ class goto_symex_statet final : public goto_statet
   goto_symex_statet(const goto_symex_statet &other) = default;
 };
 
-inline goto_statet::goto_statet(const class goto_symex_statet &s)
-  : depth(s.depth),
-    level2(s.level2),
-    value_set(s.value_set),
-    guard(s.guard),
-    reachable(s.reachable),
-    propagation(s.propagation),
-    atomic_section_id(s.atomic_section_id)
-{
-}
-
 #endif // CPROVER_GOTO_SYMEX_GOTO_SYMEX_STATE_H