Merge pull request #1245 from tautschnig/run-diagnostic

Avoid zombie and print diagnostic output if run/execve fails

Author: Daniel Kroening

regression/goto-gcc/run_diagnostic/main.i

@@ -0,0 +1,4 @@
+int main()
+{
+  return 0;
+}

regression/goto-gcc/run_diagnostic/test.desc

@@ -0,0 +1,10 @@
+CORE
+main.i
+--native-compiler /no/such/tool
+^EXIT=1$
+^SIGNAL=0$
+^execvp /no/such/tool failed: No such file or directory$
+--
+^Remove failed
+^warning: ignoring
+^CONVERSION ERROR$

src/util/run.cpp

@@ -127,10 +127,13 @@ int run(
         dup2(stdin_fd, STDIN_FILENO);
       if(stdout_fd!=STDOUT_FILENO)
         dup2(stdout_fd, STDOUT_FILENO);
+
+      errno=0;
       execvp(what.c_str(), _argv.data());
 
       /* usually no return */
-      return 1;
+      perror(std::string("execvp "+what+" failed").c_str());
+      exit(1);
     }
     else /* fork() returns new pid to the parent process */
     {