Allow offset of a single bit

This is valid - the offset can be 0 for a pointer pointing at the start
of a single byte allocation.

Author: Thomas Kiley

src/ansi-c/ansi_c_internal_additions.cpp

@@ -134,7 +134,7 @@ static size_t
 max_malloc_size(std::size_t pointer_width, std::size_t object_bits)
 {
   PRECONDITION(pointer_width >= 1);
-  PRECONDITION(object_bits < pointer_width - 1);
+  PRECONDITION(object_bits < pointer_width);
   PRECONDITION(object_bits >= 1);
   const auto offset_bits = pointer_width - object_bits;
   // We require the offset to be able to express upto allocation_size - 1,

unit/ansi-c/max_malloc_size.cpp

@@ -18,7 +18,6 @@ TEST_CASE(
 
   SECTION("Too many bits for pointer ID")
   {
-    REQUIRE_THROWS_AS(max_malloc_size(4, 3), invariant_failedt);
     REQUIRE_THROWS_AS(max_malloc_size(4, 4), invariant_failedt);
     REQUIRE_THROWS_AS(max_malloc_size(4, 5), invariant_failedt);
   }
@@ -35,6 +34,9 @@ TEST_CASE(
 
   SECTION("Valid allocation size configurations")
   {
+    // The one bit offset can be used to store 0, or -1, so we can allocate
+    // a single bit
+    REQUIRE(max_malloc_size(4, 3) == 1);
     // Here we use 4 bits for the object ID, leaving 3 for the offset
     REQUIRE(max_malloc_size(8, 4) == 8);
   }