Make public assign take level1t for rhs

Author: romainbrenguier

src/goto-symex/goto_symex_state.cpp

@@ -234,7 +234,7 @@ void goto_symex_statet::assignment(
         !check_renaming_l1(l1_rhs.expr), "rhs renaming failed on l1");
     }
 
-    value_set.assign(l1_lhs, l1_rhs.expr, ns, rhs_is_simplified, is_shared);
+    value_set.assign(l1_lhs, l1_rhs, ns, rhs_is_simplified, is_shared);
   }
 
   #if 0

src/goto-symex/symex_dead.cpp

@@ -40,7 +40,7 @@ void goto_symext::symex_dead(statet &state)
 
     level1t<exprt> l1_rhs = state.rename_level1(std::move(rhs), ns);
     // TODO: change assign to take a level1_exprt
-    state.value_set.assign(l1_code, l1_rhs.expr, ns, true, false);
+    state.value_set.assign(l1_code, l1_rhs, ns, true, false);
   }
 
   ssa_exprt ssa_lhs = l1_code.expr;

src/goto-symex/symex_decl.cpp

@@ -54,7 +54,7 @@ void goto_symext::symex_decl(statet &state, const symbol_exprt &expr)
     }();
 
     level1t<exprt> l1_rhs = state.rename_level1(std::move(rhs), ns);
-    state.value_set.assign(ssa, l1_rhs.expr, ns, true, false);
+    state.value_set.assign(ssa, l1_rhs, ns, true, false);
   }
 
   // prevent propagation

src/pointer-analysis/value_set.cpp

@@ -1117,12 +1117,12 @@ void value_sett::get_reference_set_rec(
 
 void value_sett::assign(
   const level1t<ssa_exprt> &lhs,
-  const exprt &rhs,
+  const level1t<exprt> &rhs,
   const namespacet &ns,
   bool is_simplified,
   bool add_to_sets)
 {
-  assign(lhs.expr, rhs, ns, is_simplified, add_to_sets);
+  assign(lhs.expr, rhs.expr, ns, is_simplified, add_to_sets);
 }
 
 void value_sett::assign(

src/pointer-analysis/value_set.h

@@ -395,7 +395,7 @@ class value_sett
   ///   `y` or `z` MAY, but not MUST, be overwritten.
   void assign(
     const level1t<ssa_exprt> &lhs,
-    const exprt &rhs,
+    const level1t<exprt> &rhs,
     const namespacet &ns,
     bool is_simplified,
     bool add_to_sets);