Remove controversial get_ prefix

Because nobody could decie between: get_, create_, synthesize_, etc...

Author: Lukasz A.J. Wrona

jbmc/src/java_bytecode/java_bytecode_language.cpp

@@ -1174,11 +1174,11 @@ bool java_bytecode_languaget::convert_single_method(
           get_message_handler());
       break;
     case synthetic_method_typet::INVOKEDYNAMIC_CAPTURE_CONSTRUCTOR:
-      writable_symbol.value = get_invokedynamic_synthetic_constructor(
+      writable_symbol.value = invokedynamic_synthetic_constructor(
         function_id, symbol_table, get_message_handler());
       break;
     case synthetic_method_typet::INVOKEDYNAMIC_METHOD:
-      writable_symbol.value = get_invokedynamic_synthetic_method(
+      writable_symbol.value = invokedynamic_synthetic_method(
         function_id, symbol_table, get_message_handler());
       break;
     }

jbmc/src/java_bytecode/lambda_synthesis.cpp

@@ -362,7 +362,7 @@ static const symbolt &get_or_create_method_symbol(
   return symbol_table.lookup_ref(identifier);
 }
 
-codet get_invokedynamic_synthetic_constructor(
+codet invokedynamic_synthetic_constructor(
   const irep_idt &function_id,
   symbol_table_baset &symbol_table,
   message_handlert &message_handler)
@@ -428,7 +428,7 @@ codet get_invokedynamic_synthetic_constructor(
   return std::move(result);
 }
 
-codet get_invokedynamic_synthetic_method(
+codet invokedynamic_synthetic_method(
   const irep_idt &function_id,
   symbol_table_baset &symbol_table,
   message_handlert &message_handler)

jbmc/src/java_bytecode/lambda_synthesis.h

@@ -30,12 +30,14 @@ void create_invokedynamic_synthetic_classes(
   synthetic_methods_mapt &synthetic_methods,
   message_handlert &message_handler);
 
-codet get_invokedynamic_synthetic_constructor(
+/// Create invokedynamic synthetic constructor
+codet invokedynamic_synthetic_constructor(
   const irep_idt &function_id,
   symbol_table_baset &symbol_table,
   message_handlert &message_handler);
 
-codet get_invokedynamic_synthetic_method(
+/// Create invokedynamic synthetic method
+codet invokedynamic_synthetic_method(
   const irep_idt &function_id,
   symbol_table_baset &symbol_table,
   message_handlert &message_handler);