Use helper functions in get_non_char_pointer_value

To unify the access to info about allocated memory.

Author: petr-bauch

src/memory-analyzer/analyze_symbol.cpp

@@ -344,12 +344,13 @@ exprt gdb_value_extractort::get_non_char_pointer_value(
     // expected positions. Since the allocated size is over-approximation we may
     // end up querying pass the allocated bounds and building larger array with
     // meaningless values.
-    size_t allocated_size =
-      gdb_api.query_malloc_size(c_converter.convert(expr));
+    const auto c_name = c_converter.convert(expr);
+    const auto maybe_allocated_size = get_malloc_size(c_name);
+    mp_integer allocated_size = maybe_allocated_size.has_value()
+                                  ? *maybe_allocated_size
+                                  : gdb_api.query_malloc_size(c_name);
     // get the sizeof(target_type) and thus the number of elements
-    const auto target_size_bits = pointer_offset_bits(target_type, ns);
-    CHECK_RETURN(target_size_bits.has_value());
-    const auto number_of_elements = allocated_size / (*target_size_bits / 8);
+    const auto number_of_elements = allocated_size / get_type_size(target_type);
     if(number_of_elements > 1)
     {
       array_exprt::operandst elements;