Adding unit test for does_pattern_miss_descriptor

Author: thk123

jbmc/src/java_bytecode/load_method_by_regex.h

@@ -29,6 +29,8 @@ class load_method_by_regext : public load_extra_methodst
   std::regex regex;
 
   static bool does_pattern_miss_descriptor(const std::string &pattern);
+
+  friend class load_method_by_regex_testt;
 };
 
 #endif // CPROVER_JAVA_BYTECODE_LOAD_METHOD_BY_REGEX_H

jbmc/unit/Makefile

@@ -21,6 +21,7 @@ SRC += java_bytecode/goto-programs/class_hierarchy_output.cpp \
        java_bytecode/java_types/java_generic_symbol_type.cpp \
        java_bytecode/java_types/java_type_from_string.cpp \
        java_bytecode/java_utils_test.cpp \
+       java_bytecode/load_method_by_regex.cpp \
        java_bytecode/inherited_static_fields/inherited_static_fields.cpp \
        pointer-analysis/custom_value_set_analysis.cpp \
        solvers/refinement/string_constraint_instantiation/instantiate_not_contains.cpp \

jbmc/unit/java_bytecode/load_method_by_regex.cpp

@@ -0,0 +1,103 @@
+/*******************************************************************\
+
+ Module: Unit tests for parsing generic classes
+
+ Author: Diffblue Limited
+
+\*******************************************************************/
+
+#include <java_bytecode/load_method_by_regex.h>
+#include <testing-utils/catch.hpp>
+
+class load_method_by_regex_testt
+{
+public:
+  static bool does_pattern_miss_descriptor(const std::string &pattern)
+  {
+    return load_method_by_regext::does_pattern_miss_descriptor(pattern);
+  }
+};
+
+SCENARIO(
+  "load_method_by_regex::does_pattern_miss_descriptor",
+  "[core][java_bytecode][load_method_by_regex]")
+{
+  GIVEN("A string with a java prefix and no descriptor")
+  {
+    const std::string pattern = "java::com.diffblue.ClassName.methodName";
+    WHEN("When calling does_pattern_miss_descriptor")
+    {
+      bool result =
+        load_method_by_regex_testt::does_pattern_miss_descriptor(pattern);
+      THEN("It should miss discriptor")
+      {
+        REQUIRE(result);
+      }
+    }
+  }
+  GIVEN("A string with a java prefix and a descriptor")
+  {
+    const std::string pattern = "java::com.diffblue.ClassName.methodName:()V";
+    WHEN("When calling does_pattern_miss_descriptor")
+    {
+      bool result =
+        load_method_by_regex_testt::does_pattern_miss_descriptor(pattern);
+      THEN("It should have the discriptor")
+      {
+        REQUIRE_FALSE(result);
+      }
+    }
+  }
+  GIVEN("A string without a java prefix and without a descriptor")
+  {
+    const std::string pattern = "com.diffblue.ClassName.methodName";
+    WHEN("When calling does_pattern_miss_descriptor")
+    {
+      bool result =
+        load_method_by_regex_testt::does_pattern_miss_descriptor(pattern);
+      THEN("It should miss discriptor")
+      {
+        REQUIRE(result);
+      }
+    }
+  }
+  GIVEN("A string without a java prefix and with a descriptor")
+  {
+    const std::string pattern = "com.diffblue.ClassName.methodName:()V";
+    WHEN("When calling does_pattern_miss_descriptor")
+    {
+      bool result =
+        load_method_by_regex_testt::does_pattern_miss_descriptor(pattern);
+      THEN("It should have the discriptor")
+      {
+        REQUIRE_FALSE(result);
+      }
+    }
+  }
+  GIVEN("A string with an almost java prefix and no descriptor")
+  {
+    const std::string pattern = "java:com.diffblue.ClassName.methodName";
+    WHEN("When calling does_pattern_miss_descriptor")
+    {
+      bool result =
+        load_method_by_regex_testt::does_pattern_miss_descriptor(pattern);
+      THEN("It should classify the last : as a descriptor")
+      {
+        REQUIRE_FALSE(result);
+      }
+    }
+  }
+  GIVEN("A string with an almost java prefix and with a descriptor")
+  {
+    const std::string pattern = "java:com.diffblue.ClassName.methodName:()V";
+    WHEN("When calling does_pattern_miss_descriptor")
+    {
+      bool result =
+        load_method_by_regex_testt::does_pattern_miss_descriptor(pattern);
+      THEN("It should have the discriptor")
+      {
+        REQUIRE_FALSE(result);
+      }
+    }
+  }
+}