Remove value_set_abstract_valuet

It has been made redundant by the VSD changes over the past few months,
and its continued presence is simply now confusing.

Author: jezhiggins

scripts/expected_doxygen_warnings.txt

@@ -33,7 +33,7 @@ warning: Included by graph for 'message.h' not generated, too many nodes (118),
 warning: Included by graph for 'namespace.h' not generated, too many nodes (110), threshold is 60. Consider increasing DOT_GRAPH_MAX_NODES.
 warning: Included by graph for 'pointer_expr.h' not generated, too many nodes (116), threshold is 60. Consider increasing DOT_GRAPH_MAX_NODES.
 warning: Included by graph for 'prefix.h' not generated, too many nodes (85), threshold is 60. Consider increasing DOT_GRAPH_MAX_NODES.
-warning: Included by graph for 'simplify_expr.h' not generated, too many nodes (79), threshold is 60. Consider increasing DOT_GRAPH_MAX_NODES.
+warning: Included by graph for 'simplify_expr.h' not generated, too many nodes (78), threshold is 60. Consider increasing DOT_GRAPH_MAX_NODES.
 warning: Included by graph for 'std_code.h' not generated, too many nodes (79), threshold is 60. Consider increasing DOT_GRAPH_MAX_NODES.
 warning: Included by graph for 'std_expr.h' not generated, too many nodes (241), threshold is 60. Consider increasing DOT_GRAPH_MAX_NODES.
 warning: Included by graph for 'std_types.h' not generated, too many nodes (96), threshold is 60. Consider increasing DOT_GRAPH_MAX_NODES.

src/analyses/Makefile

@@ -47,7 +47,6 @@ SRC = ai.cpp \
       variable-sensitivity/interval_abstract_value.cpp \
       variable-sensitivity/three_way_merge_abstract_interpreter.cpp \
       variable-sensitivity/value_set_abstract_object.cpp \
-      variable-sensitivity/value_set_abstract_value.cpp \
       variable-sensitivity/value_set_pointer_abstract_object.cpp \
       variable-sensitivity/variable_sensitivity_configuration.cpp \
       variable-sensitivity/variable_sensitivity_dependence_graph.cpp \

src/analyses/variable-sensitivity/value_set_abstract_value.cpp

@@ -33,8 +33,6 @@ vsd_configt vsd_configt::from_options(const optionst &options)
   config.context_tracking.last_write_context = true;
   config.context_tracking.data_dependency_context =
     options.get_bool_option("data-dependencies");
-  config.advanced_sensitivities.new_value_set =
-    options.get_bool_option("new-value-set");
 
   config.flow_sensitivity = (options.get_bool_option("flow-insensitive"))
                               ? flow_sensitivityt::insensitive

src/analyses/variable-sensitivity/value_set_abstract_value.h

@@ -7,7 +7,6 @@
 \*******************************************************************/
 #include "variable_sensitivity_object_factory.h"
 #include "full_array_abstract_object.h"
-#include "value_set_abstract_value.h"
 #include "value_set_pointer_abstract_object.h"
 
 template <class context_classt>
@@ -144,11 +143,6 @@ variable_sensitivity_object_factoryt::get_abstract_object(
     return initialize_abstract_object<interval_abstract_valuet>(
       followed_type, top, bottom, e, environment, ns, configuration);
   case VALUE_SET:
-    if(configuration.advanced_sensitivities.new_value_set)
-    {
-      return initialize_abstract_object<value_set_abstract_valuet>(
-        followed_type, top, bottom, e, environment, ns, configuration);
-    }
     return initialize_abstract_object<value_set_abstract_objectt>(
       followed_type, top, bottom, e, environment, ns, configuration);
 

src/analyses/variable-sensitivity/variable_sensitivity_configuration.cpp

@@ -27,7 +27,6 @@ SRC += analyses/ai/ai.cpp \
        analyses/variable-sensitivity/last_written_location.cpp \
        analyses/variable-sensitivity/value_expression_evaluation/assume.cpp \
        analyses/variable-sensitivity/value_expression_evaluation/expression_evaluation.cpp \
-       analyses/variable-sensitivity/value_set/abstract_value.cpp \
        analyses/variable-sensitivity/value_set_abstract_object/meet.cpp \
        analyses/variable-sensitivity/value_set_abstract_object/merge.cpp \
        analyses/variable-sensitivity/variable_sensitivity_test_helpers.cpp \