Remove obsolete functions is_pointer(), is_struct(), etc. from std_expr.h

A previous commit introduced e.g. function is_pointer() to check type.id() ==
ID_pointer. These have become obsolete as these expressions are now used
directly.

Author: danpoe

src/util/c_types_util.h

@@ -49,15 +49,15 @@ inline bool is_c_int_derivate(const typet &type)
 /// of the pointer has been a char type in the c program.
 inline bool is_c_char_pointer(const typet &type)
 {
-  return is_pointer(type) && is_c_char(type.subtype());
+  return type.id() == ID_pointer && is_c_char(type.subtype());
 }
 
 /// This function checks, whether type is a pointer and the target type
 /// has been some kind of int type in the c program.
 /// is_c_int_derivate answers is used for checking the int type.
 inline bool is_c_int_derivate_pointer(const typet &type)
 {
-  return is_pointer(type) && is_c_int_derivate(type.subtype());
+  return type.id() == ID_pointer && is_c_int_derivate(type.subtype());
 }
 
 /// This function checks, whether the type
@@ -73,7 +73,7 @@ inline bool is_c_enum(const typet &type)
 /// \param c_enum the enum type memeber_name is supposed to be part of.
 /// \return value a constant, that could be assigned as value for an expression
 /// with type c_enum.
-constant_exprt convert_memeber_name_to_enum_value(
+constant_exprt convert_member_name_to_enum_value(
   const std::string &member_name,
   const c_enum_typet &c_enum)
 {

src/util/std_types.h

@@ -313,13 +313,6 @@ inline bool can_cast_type<struct_typet>(const typet &type)
   return type.id() == ID_struct;
 }
 
-/// This method tests,
-/// if the given typet is a struct
-inline bool is_struct(const typet &type)
-{
-  return type.id() == ID_struct;
-}
-
 /// \brief Cast a typet to a \ref struct_typet
 ///
 /// This is an unchecked conversion. \a type must be known to be \ref
@@ -1015,12 +1008,6 @@ class array_typet:public type_with_subtypet
     return size().is_nil();
   }
 };
-/// This method tests,
-/// if the given typet is an array_typet
-inline bool is_array(const typet &type)
-{
-  return type.id() == ID_array;
-}
 
 /// Check whether a reference to a typet is a \ref array_typet.
 /// \param type: Source type.
@@ -1569,18 +1556,11 @@ inline pointer_typet &to_pointer_type(typet &type)
   return static_cast<pointer_typet &>(type);
 }
 
-/// This method tests,
-/// if the given typet is a pointer.
-inline bool is_pointer(const typet &type)
-{
-  return type.id() == ID_pointer;
-}
-
 /// This method tests,
 /// if the given typet is a pointer of type void.
 inline bool is_void_pointer(const typet &type)
 {
-  return is_pointer(type) && type.subtype().id() == ID_empty;
+  return type.id() == ID_pointer && type.subtype().id() == ID_empty;
 }
 
 /// The reference type