Moved the logic of select_pointer_type into test-gen

The base classs behaviour now leaves the type untouched. This requires
no further testing so the original tests are now removed.

The select_pointer_type class is now passed in to allow configurable
behaviour. However, on this branch the behaviour is trivial.

Author: thk123

regression/cbmc-java/instance-method-user-interface-field/A.class

@@ -14,6 +14,7 @@ Author: Reuben Thomas, [email protected]
 #include "goto-programs/goto_model.h"
 #include "goto-programs/remove_skip.h"
 
+#include <memory>
 #include "java_bytecode/java_object_factory.h" // gen_nondet_init
 
 #include "util/irep_ids.h"
@@ -88,6 +89,7 @@ static goto_programt::targett insert_nondet_init_code(
     allocation_typet::DYNAMIC,
     !nullable,
     max_nondet_array_length,
+    std::make_shared<select_pointer_typet>(),
     update_in_placet::NO_UPDATE_IN_PLACE);
 
   // Convert this code into goto instructions

regression/cbmc-java/instance-method-user-interface-field/B.class

@@ -2,7 +2,6 @@ SRC = bytecode_info.cpp \
       character_refine_preprocess.cpp \
       ci_lazy_methods.cpp \
       expr2java.cpp \
-      get_concrete_class_alphabetically.cpp \
       jar_file.cpp \
       java_bytecode_convert_class.cpp \
       java_bytecode_convert_method.cpp \