remove mathematical_typet() constructor, which produces an incomplete object

Author: Daniel Kroening

src/solvers/smt2/smt2_parser.cpp

@@ -1028,7 +1028,7 @@ typet smt2_parsert::function_signature_definition()
     return sort();
   }
 
-  mathematical_function_typet result;
+  mathematical_function_typet result({}, nil_typet());
 
   while(peek()!=CLOSE)
   {
@@ -1081,7 +1081,7 @@ typet smt2_parsert::function_signature_declaration()
     return sort();
   }
 
-  mathematical_function_typet result;
+  mathematical_function_typet result({}, nil_typet());
 
   while(peek()!=CLOSE)
   {

src/util/std_types.h

@@ -1686,11 +1686,6 @@ inline complex_typet &to_complex_type(typet &type)
 class mathematical_function_typet:public typet
 {
 public:
-  mathematical_function_typet():typet(ID_mathematical_function)
-  {
-    subtypes().resize(2);
-  }
-
   // the domain of the function is composed of zero, one, or
   // many variables
   class variablet:public irept
@@ -1720,6 +1715,14 @@ class mathematical_function_typet:public typet
 
   using domaint=std::vector<variablet>;
 
+  mathematical_function_typet(
+    const domaint &_domain, const typet &_codomain):typet(ID_mathematical_function)
+  {
+    subtypes().resize(2);
+    domain()=_domain;
+    codomain()=_codomain;
+  }
+
   domaint &domain()
   {
     return (domaint &)subtypes()[0].subtypes();