Add validate() methods to (components of) goto models

Author: danpoe

src/goto-programs/goto_functions.h

@@ -130,6 +130,19 @@ class goto_functionst
 
   std::vector<function_mapt::const_iterator> sorted() const;
   std::vector<function_mapt::iterator> sorted();
+
+  /// Check that the goto functions are well-formed
+  ///
+  /// The validation mode indicates whether well-formedness check failures are
+  /// reported via DATA_INVARIANT violations or exceptions.
+  void validate(const namespacet &ns, const validation_modet vm) const
+  {
+    for(const auto &entry : function_map)
+    {
+      const goto_functiont &goto_function = entry.second;
+      goto_function.validate(ns, vm);
+    }
+  }
 };
 
 #define Forall_goto_functions(it, functions) \

src/util/exception_utils.h

@@ -118,10 +118,9 @@ incorrect_goto_program_exceptiont::incorrect_goto_program_exceptiont(
   Diagnostic &&diagnostic,
   Diagnostics &&... diagnostics)
   : message(std::move(message)),
-    diagnostics(
-      detail::assemble_diagnostics(
-        std::forward(diagnostic),
-        std::forward<Diagnostics>(diagnostics)...))
+    diagnostics(detail::assemble_diagnostics(
+      std::forward(diagnostic),
+      std::forward<Diagnostics>(diagnostics)...))
 {
 }