Clean up set_properties helper method

set_properties has no return value.

Author: peterschrammel

jbmc/src/jbmc/jbmc_parse_options.cpp

@@ -561,8 +561,8 @@ int jbmc_parse_optionst::doit()
 
     goto_modelt &goto_model = *goto_model_ptr;
 
-    if(set_properties(goto_model))
-      return 7; // should contemplate EX_USAGE from sysexits.h
+    if(cmdline.isset("property"))
+      ::set_properties(goto_model, cmdline.get_values("property"));
 
     if(
       options.get_bool_option("program-only") ||
@@ -721,14 +721,6 @@ int jbmc_parse_optionst::doit()
   }
 }
 
-bool jbmc_parse_optionst::set_properties(goto_modelt &goto_model)
-{
-  if(cmdline.isset("property"))
-    ::set_properties(goto_model, cmdline.get_values("property"));
-
-  return false;
-}
-
 int jbmc_parse_optionst::get_goto_program(
   std::unique_ptr<goto_modelt> &goto_model,
   const optionst &options)

jbmc/src/jbmc/jbmc_parse_options.h

@@ -128,8 +128,6 @@ class jbmc_parse_optionst : public parse_options_baset
     std::unique_ptr<goto_modelt> &goto_model, const optionst &);
   bool show_loaded_functions(const abstract_goto_modelt &goto_model);
   bool show_loaded_symbols(const abstract_goto_modelt &goto_model);
-
-  bool set_properties(goto_modelt &goto_model);
 };
 
 #endif // CPROVER_JBMC_JBMC_PARSE_OPTIONS_H